Hide binding details if the svc instance is not bindable #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
force-pushed
the
nonBindable
branch
from
aac552b
to
e9ff1e0
Compare
prydonius
reviewed
Nov 8, 2018
| ); | ||
| } else { | ||
| bindingSection = ( | ||
| <h5 className="padding-b-big"> |
There was a problem hiding this comment.
I would keep the <h2>Bindings</h2> heading, and then just add a paragraph with a message like "This Instance cannot be bound to applications."
migmartri
approved these changes
Nov 9, 2018
| @@ -208,5 +230,32 @@ context("when all the components are loaded", () => { | |||
| ).toExist(); | |||
| expect(wrapper).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it("should not show bindings information if the class is not bindable", () => { | |||
| const classes = { | |||
There was a problem hiding this comment.
Maybe you can share these classes in the tests and only override the spec.bindable value during mount?
|
@prydonius PTAL, do you think the format is okay now? |
it looks good to me |
prydonius
approved these changes
Nov 9, 2018
| <BindingList bindingsWithSecrets={bindings} removeBinding={this.props.removeBinding} /> | ||
| ); | ||
| } else { | ||
| bindingSection = <p>This instance cannot be bound to applications</p>; |
There was a problem hiding this comment.
let's add a full stop at the end of this sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456