Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48
I add a way to disable the creation of the Prometheus datasource in Grafana because it's yet done by the Prometheus Operator helm chart.
I also add an helper for the labels used in selectors in different resources.
I tried to reuse the things defined in values.yaml. It works fine for rules as i can reuse
.Values.prometheus.serverFiles.rules
but it's not possible to do the same thing for the scraping part as.Values.prometheus.extraScrapeConfigs
is a string and not structured data and i can not see a way to convert that string to a Go structure