Auto register edge node #1184

sids-b · 2019-10-10T06:38:55Z

What type of PR is this?
Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
Support auto-register edge nodes. We can still allow manual addition of nodes for the administrators to additionally configure nodes by adding labels and other fields.

Which issue(s) this PR fixes:
Fixes #881

Special notes for your reviewer:
#1045 will be fixed in next PR

Does this PR introduce a user-facing change?:

sids-b · 2019-10-10T06:39:42Z

/cc @subpathdev @kadisi

sids-b · 2019-10-10T06:48:27Z

/cc @qizha @Baoqiang-Zhang

kadisi · 2019-10-10T11:19:07Z

docs/getting-started/usage.md

+
+ Make sure role is set to edge for the node. For this a key of the form `"node-role.kubernetes.io/edge"` must be present in `labels` tag of `metadata`.
+ Please ensure to add the label `node-role.kubernetes.io/edge` to the `build/node.json` file.
+


Why support manual registration since it supports automatic registration?

We can still allow manual addition of nodes for the administrators to additionally configure nodes by adding labels and other fields. By default only role label and name label is added. But if someone wants to add nodes with common labels so that they can be grouped together, it can be useful.

cloud/pkg/edgecontroller/controller/upstream.go

tests/e2e/edgesite/edgesite_suite_test.go

kadisi · 2019-10-16T07:20:07Z

Suppose there already exist a node (named node1) in kubernetes, and user want to add a new edged node(also named node1, Maybe he doesn't know that there is already a node named node1.). We assume that they set the same projectid 。 What will happens?

sids-b · 2019-10-16T08:38:57Z

Suppose there already exist a node (named node1) in kubernetes, and user want to add a new edged node(also named node1, Maybe he doesn't know that there is already a node named node1.). We assume that they set the same projectid 。 What will happens?

Both the nodes will start updating the status of the same node. It happens with kubelet also if 2 machines have same hostname.

kubeedge-bot · 2019-10-21T06:32:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sids-b

If they are not already assigned, you can assign the PR to them by writing /assign @sids-b in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kevin-wangzefeng

The node create action (registration) should be triggered explicitly from an edge node, and CloudCore only reflect the request to call vanilla node creation.

Implicity node auto registration can't offer the same behaviour with upstream in cases that user unregister a node and then delete the machine:

edge node would continue reporting node status, while CloudCore can't distinguish that stat whether a node is a new or unregistered one.

cloud/pkg/edgecontroller/controller/upstream.go

Co-Authored-By: Kevin Wang <wangzefeng@huawei.com>

sids-b · 2019-10-22T05:31:51Z

I like this new feature of github which directly lets you commit the review of reviewers :)

kadisi · 2019-10-22T05:59:44Z

docs/setup/setup.md

@@ -147,7 +147,8 @@ The cert/key will be generated in the `/etc/kubeedge/ca` and `/etc/kubeedge/cert


 #### Deploy the edge node
-We have provided a sample node.json to add a node in kubernetes. Please make sure edge-node is added in kubernetes. Run below steps to add edge-node.
+KubeEdge supports auto registration of edge-nodes but we have provided a sample node.json to manually add a node in kubernetes if required. 
+Run below steps to add edge-node.


We should add the register-node: true configuration in line287 of setup.md

kadisi · 2019-10-22T06:03:15Z

edge/pkg/edged/edged.go

+			for {
+				resource := fmt.Sprintf("%s/%s/%s", e.namespace, model.ResourceTypeNodeStatus, e.nodeName)
+				msg := message.BuildMsg(modules.MetaGroup, "", modules.EdgedModuleName, resource, model.InsertOperation, "")
+				_, err := e.context.SendSync("websocket", *msg, 60*time.Second)


for websocket , Recommended to use constants 。

kubeedge/edge/pkg/edgehub/module.go

Line 11 in 8819f62

ModuleNameEdgeHub = "websocket"

fisherxu · 2019-10-22T06:35:08Z

cloud/pkg/edgecontroller/controller/upstream.go

@@ -372,6 +384,32 @@ func (uc *UpstreamController) updateNodeStatus(stop chan struct{}) {
 			}

 			switch msg.GetOperation() {
+			case model.InsertOperation:
+				klog.Infof("Received register node request, creating node")
+				if _, err := uc.createNode(name); err != nil {


We should receive the node obj instead of nodename from edge, kubelet has some features(flags like taints/labels) that set to node.

cloud/pkg/edgecontroller/controller/upstream.go

fisherxu · 2019-10-22T06:46:48Z

docs/getting-started/usage.md

@@ -106,14 +106,40 @@ The cert/key will be generated in the `/etc/kubeedge/ca` and `/etc/kubeedge/cert
 ### Run Edge

 #### Deploy the Edge node
-We have provided a sample node.json to add a node in kubernetes. Please make sure edge-node is added in kubernetes. Run below steps to add edge-node.
+KubeEdge supports auto registration of edge-nodes but we have provided a sample node.json to manually add a node in kubernetes if required. 
+Run below steps to add edge-node.


Suggested change

Run below steps to add edge-node.

KubeEdge supports auto registration of edge-nodes by default. But we also support manually add edge-nodes in kubernetes if required.

Run below steps to add edge-node manually.

fisherxu · 2019-10-22T06:51:06Z

docs/getting-started/usage.md

+        cp $GOPATH/src/github.com/kubeedge/kubeedge/build/node.json ~/cmd/yaml
+    ```
+
+ Make sure role is set to edge for the node. For this a key of the form `"node-role.kubernetes.io/edge"` must be present in `labels` tag of `metadata`.


Can delete this line? Add lable is enough. :)

fisherxu · 2019-10-22T06:52:11Z

docs/getting-started/usage.md

+    }
+    ```
+    **Note: you need to remember `metadata.name` , because edgecore need it**.
+ If role is not set for the node, the pods, configmaps and secrets created/updated in the cloud cannot be synced with the node they are targeted for.


lable is not set for the node. lable and role is different in k8s

fisherxu · 2019-12-10T02:17:51Z

Any updates?

kuramal · 2019-12-31T10:33:14Z

@sids-b @fisherxu Is there any plan of update?

fisherxu · 2020-01-22T07:33:40Z

/close
Dumplicate with #1401

kubeedge-bot · 2020-01-22T07:33:46Z

@fisherxu: Closed this PR.

In response to this:

/close
Dumplicate with #1401

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubeedge-bot requested review from chendave and fisherxu October 10, 2019 06:39

kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2019

kubeedge-bot requested review from kadisi and subpathdev October 10, 2019 06:39

sids-b force-pushed the auto branch from cf84b2e to e751119 Compare October 10, 2019 06:47

kubeedge-bot requested review from Baoqiang-Zhang and qizha October 10, 2019 06:48

kadisi reviewed Oct 10, 2019

View reviewed changes

fisherxu reviewed Oct 10, 2019

View reviewed changes

cloud/pkg/edgecontroller/controller/upstream.go Show resolved Hide resolved

fisherxu reviewed Oct 11, 2019

View reviewed changes

tests/e2e/edgesite/edgesite_suite_test.go Show resolved Hide resolved

fisherxu requested a review from kevin-wangzefeng October 18, 2019 08:04

sids-b force-pushed the auto branch from 3c2eaac to e13cc63 Compare October 21, 2019 06:21

kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2019

add edge auto register

82288b8

sids-b force-pushed the auto branch from e13cc63 to 82288b8 Compare October 21, 2019 06:24

sids-b added 2 commits October 21, 2019 11:57

add auto register information in docs

8cd5859

updated e2e tests to support auto-register

76b790c

kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2019

kevin-wangzefeng reviewed Oct 21, 2019

View reviewed changes

kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2019

kevin-wangzefeng reviewed Oct 21, 2019

View reviewed changes

cloud/pkg/edgecontroller/controller/upstream.go Outdated Show resolved Hide resolved

added register-node flag at edge

656f553

sids-b force-pushed the auto branch from e8c09c5 to 656f553 Compare October 21, 2019 15:13

Update cloud/pkg/edgecontroller/controller/upstream.go

4e23de4

Co-Authored-By: Kevin Wang <wangzefeng@huawei.com>

kadisi reviewed Oct 22, 2019

View reviewed changes

fisherxu reviewed Oct 22, 2019

View reviewed changes

kubeedge-bot closed this Jan 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto register edge node #1184

Auto register edge node #1184

sids-b commented Oct 10, 2019 •

edited by kevin-wangzefeng

sids-b commented Oct 10, 2019

sids-b commented Oct 10, 2019

kadisi Oct 10, 2019

sids-b Oct 10, 2019

kadisi commented Oct 16, 2019

sids-b commented Oct 16, 2019

kubeedge-bot commented Oct 21, 2019

kevin-wangzefeng left a comment

sids-b commented Oct 22, 2019

kadisi Oct 22, 2019

kadisi Oct 22, 2019

fisherxu Oct 22, 2019

fisherxu Oct 22, 2019

fisherxu Oct 22, 2019

fisherxu Oct 22, 2019

fisherxu commented Dec 10, 2019

kuramal commented Dec 31, 2019

fisherxu commented Jan 22, 2020

kubeedge-bot commented Jan 22, 2020


		+ Make sure role is set to edge for the node. For this a key of the form `"node-role.kubernetes.io/edge"` must be present in `labels` tag of `metadata`.
		+ Please ensure to add the label `node-role.kubernetes.io/edge` to the `build/node.json` file.

	Run below steps to add edge-node.
	KubeEdge supports auto registration of edge-nodes by default. But we also support manually add edge-nodes in kubernetes if required.
	Run below steps to add edge-node manually.

Auto register edge node #1184

Auto register edge node #1184

Conversation

sids-b commented Oct 10, 2019 • edited by kevin-wangzefeng

sids-b commented Oct 10, 2019

sids-b commented Oct 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kadisi commented Oct 16, 2019

sids-b commented Oct 16, 2019

kubeedge-bot commented Oct 21, 2019

kevin-wangzefeng left a comment

Choose a reason for hiding this comment

sids-b commented Oct 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fisherxu commented Dec 10, 2019

kuramal commented Dec 31, 2019

fisherxu commented Jan 22, 2020

kubeedge-bot commented Jan 22, 2020

sids-b commented Oct 10, 2019 •

edited by kevin-wangzefeng