Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge node auto register #1401

Merged
merged 3 commits into from Jan 21, 2020
Merged

edge node auto register #1401

merged 3 commits into from Jan 21, 2020

Conversation

@kuramal
Copy link
Member

kuramal commented Jan 15, 2020

What type of PR is this?

/kind documentation
/kind feature

What this PR does / why we need it:
support edge node auto register

Which issue(s) this PR fixes:
Fixes #881

Does this PR introduce a user-facing change?:

Edge node auto register
Now the edge node will automatically register by default,  If you want register manually, you should set the config register-node of edged with false
@kuramal kuramal force-pushed the kuramal:node-auto-regist branch from b22381d to 5c1b830 Jan 15, 2020
@kevin-wangzefeng

This comment has been minimized.

Copy link
Member

kevin-wangzefeng commented Jan 15, 2020

Please add release-note section in PR description

edge/conf/edge.yaml Outdated Show resolved Hide resolved
@kuramal kuramal force-pushed the kuramal:node-auto-regist branch 3 times, most recently from a22da2d to e91b4f4 Jan 16, 2020
kuramal added 2 commits Jan 15, 2020
Signed-off-by: Su Xiaolin <linxxnil@126.com>
optimize some code

Signed-off-by: Su Xiaolin <linxxnil@126.com>
@kuramal kuramal force-pushed the kuramal:node-auto-regist branch from e91b4f4 to 3424c6d Jan 20, 2020
@kuramal

This comment has been minimized.

Copy link
Member Author

kuramal commented Jan 20, 2020

@fisherxu @kadisi update with new config api, PTAL

edgesite/conf/edgeSite.yaml Outdated Show resolved Hide resolved
edge/conf/edge.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,43 @@
# Deploy Edge Node Manually

This comment has been minimized.

Copy link
@fisherxu

fisherxu Jan 21, 2020

Member

How to jump here from setup.md? I'd suggest to keep it in setup.md. For example:

Deploy the edge node

Edge node can be registered automatically.

Deploy Edge Node Manually

If you want to deploy edge node manually, here is an example.

Maybe we need reminder users to set register-node to false here.

This comment has been minimized.

Copy link
@fisherxu

fisherxu Jan 21, 2020

Member

please help modify it more clear,like: L5-L16, we can just delete it.

@kuramal kuramal force-pushed the kuramal:node-auto-regist branch 2 times, most recently from ace40e5 to 5848488 Jan 21, 2020
Signed-off-by: Su Xiaolin <linxxnil@126.com>
@fisherxu

This comment has been minimized.

Copy link
Member

fisherxu commented Jan 21, 2020

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm label Jan 21, 2020
@kevin-wangzefeng

This comment has been minimized.

Copy link
Member

kevin-wangzefeng commented Jan 21, 2020

/approve

@kubeedge-bot

This comment has been minimized.

Copy link
Collaborator

kubeedge-bot commented Jan 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot merged commit 19dcd2d into kubeedge:master Jan 21, 2020
1 of 2 checks passed
1 of 2 checks passed
tide Not mergeable. Needs approved label.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.