[Sig-Security] Generation of SLSA3+ provenance for KubeEdge release artifacts #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
kind/cleanup
kubeedge-bot
added
the
size/M
vincentgoat
force-pushed
the
slsa
branch
6 times, most recently
from
5f7f4e3
to
7fe80cc
Compare
kubeedge-bot
added
size/L
vincentgoat
force-pushed
the
slsa
branch
16 times, most recently
from
b9d8ced
to
df4aa1b
Compare
kubeedge-bot
removed
the
do-not-merge/work-in-progress
vincentgoat
force-pushed
the
slsa
branch
2 times, most recently
from
536fc4f
to
5efb1cf
Compare
kubeedge-bot
added
size/M
gy95
reviewed
Oct 14, 2022
.github/workflows/release.yml
Outdated
| @@ -20,8 +20,6 @@ jobs: | |||
| - linux | |||
| arch: | |||
gy95
reviewed
Oct 14, 2022
.github/workflows/release.yml
Outdated
|
|
||
| _output/release/${{ github.ref_name }}/${{ matrix.target }}-${{ github.ref_name }}-${{ matrix.os }}-${{ env.output_arch }}.tar.gz | ||
| _output/release/${{ github.ref_name }}/checksum_${{ matrix.target }}-${{ github.ref_name }}-${{ matrix.os }}-${{ env.output_arch }}.tar.gz.txt | ||
| build-hash: |
There was a problem hiding this comment.
add a blank line between the two jobs and between the two actions to make it readable
vincentgoat
force-pushed
the
slsa
branch
2 times, most recently
from
b39da38
to
e831628
Compare
8 tasks
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
kubeedge-bot
added
size/L
Signed-off-by: vincentgoat <linguohui1@huawei.com>
vincentgoat
added
the
sig/security
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vincentgoat linguohui1@huawei.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Generation of SLSA3+ provenance for KubeEdge, generating non-forgeable SLSA provenance on GitHub that meets the build and provenance requirements for SLSA level 3 and above.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: YES
1. Before merging this PR
Please create a
Repository variablesin the repo kubeedge.Steps: Repo kubeedge > settings > Security/Secretes and variables > Actions > Variables > New repositories variables
New the variable:
DOCKERHUB_USER_NAME: {the value is same with dockerhub username}2. Here is how we verify provenance generated by SLSA generator (Binary artifacts):
Download slsa-verifier tools. FYI: https://github.com/slsa-framework/slsa-verifier
Example:
$ ./slsa-verifier-linux-amd64 verify-artifact kubeedge-v1.xx.xx-linux-arm.tar.gz --provenance-path attestation.intoto.jsonl --source-uri github.com/kubeedge/kubeedge --source-tag v1.xx.xx
If the results return the following means verifying successfully.
PASSED: Verified SLSA provenanceOtherwise failed.
expected hash 'xxx' not found: artifact hash does not match provenance subjectNote: Files
kubeedge-v1.xx.xx-linux-arm.tar.gzandattestation.intoto.jsonlare release artifacts that show at KubeEdge RELEASE pages.3. Verify container images' provenance
FYI: https://github.com/slsa-framework/slsa-github-generator/tree/main/internal/builders/container#verification
Examples:
$ COSIGN_EXPERIMENTAL=1 cosign verify-attestation --type slsaprovenance --policy policy.cue kubeedge/admission:v1.x.x