Skip to content

cloudhub enhancement #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

cloudhub enhancement #5585

merged 1 commit into from
Jul 18, 2024

Conversation

@spambot000
Copy link
Contributor

@spambot000 spambot000 commented May 3, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Enhance access control of CloudHub API

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. Some edge nodes with older version certificates may not be authenticated by cloudcore if this feature is turned on.

@kubeedge-bot kubeedge-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 3, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 3, 2024
@spambot000 spambot000 force-pushed the cloudhub_enhance branch 3 times, most recently from 8615bb2 to cfb7c95 Compare May 4, 2024 02:09
Shelley-BaoYue
Shelley-BaoYue reviewed May 6, 2024
View reviewed changes
Shelley-BaoYue
Shelley-BaoYue reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to update vendor, you should update go.mod file and then execute hack/update-vendor.sh and update-vendor-license.sh.

@spambot000 spambot000 force-pushed the cloudhub_enhance branch 3 times, most recently from de711eb to 3fdaf49 Compare May 26, 2024 10:55
@spambot000
Copy link
Contributor Author

spambot000 commented May 26, 2024

@Shelley-BaoYue I've updated the package authorization and added some test cases.

@spambot000 spambot000 requested a review from Shelley-BaoYue May 26, 2024 12:41
@spambot000 spambot000 force-pushed the cloudhub_enhance branch 2 times, most recently from b4e3cba to 093ff8c Compare June 1, 2024 06:33
@Shelley-BaoYue Shelley-BaoYue added this to the v1.18 milestone Jun 6, 2024
@spambot000 spambot000 force-pushed the cloudhub_enhance branch 6 times, most recently from 18460de to 4344fc1 Compare June 22, 2024 11:58
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
Shelley-BaoYue
Shelley-BaoYue reviewed Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. : ）
Please rebase newest master branch

staging/src/github.com/kubeedge/viaduct/pkg/client/quic.go Outdated
"github.com/lucas-clemente/quic-go"
"k8s.io/klog/v2"
quic "github.com/lucas-clemente/quic-go"
klog "k8s.io/klog/v2"
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"github.com/lucas-clemente/quic-go"
"k8s.io/klog/v2"
is enough. same with other places, but I don't think it's going to affect anything. : )

Copy link
Contributor Author

@spambot000 spambot000 Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Please review again.

@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024
@spambot000 spambot000 force-pushed the cloudhub_enhance branch 5 times, most recently from 9e48d93 to 8f0bcb6 Compare July 17, 2024 12:54
cloudhub enhancement
b717535 
Signed-off-by: spambot000 <jkjkjk0309@163.com>
fisherxu
fisherxu reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Overall looks great!
/assign @WillardHu @Shelley-BaoYue

@kubeedge-bot
Copy link
Collaborator

kubeedge-bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
Shelley-BaoYue
Shelley-BaoYue reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@kubeedge-bot kubeedge-bot merged commit 24a26bb into kubeedge:master Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisherxu fisherxu fisherxu left review comments

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

@gy95 gy95 Awaiting requested review from gy95

@Poor12 Poor12 Awaiting requested review from Poor12

@rohitsardesai83 rohitsardesai83 Awaiting requested review from rohitsardesai83

Assignees

@WillardHu WillardHu

@Shelley-BaoYue Shelley-BaoYue

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

5 participants

@spambot000 @kubeedge-bot @fisherxu @Shelley-BaoYue @WillardHu