Skip to content

Add mapper support device data writing proposal#5662

Merged
kubeedge-bot merged 2 commits into
kubeedge:masterfrom
wbc6080:device-writing-proposal
Oct 18, 2024
Merged

Add mapper support device data writing proposal#5662
kubeedge-bot merged 2 commits into
kubeedge:masterfrom
wbc6080:device-writing-proposal

Conversation

@wbc6080
Copy link
Copy Markdown
Collaborator

@wbc6080 wbc6080 commented Jun 11, 2024

What type of PR is this?
/kind design

What this PR does / why we need it:
Add mapper support device data writing proposal
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/design Categorizes issue or PR as related to design. label Jun 11, 2024
@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
@wbc6080 wbc6080 changed the title Add mapper support device data writing proposal [WIP]Add mapper support device data writing proposal Jun 11, 2024
@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2024
@Shelley-BaoYue Shelley-BaoYue added this to the v1.18 milestone Jun 11, 2024
@Shelley-BaoYue Shelley-BaoYue modified the milestones: v1.18, v1.19 Jul 31, 2024
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2024
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really interesting feature, had a minor comment.

Comment on lines +35 to +37
Therefore, this solution shown bellow refers to the way the Mapper Framework data plane processes device data and provides a
device writing interface on the data plane. With this interface, users can directly send device write commands
to the mapper data plane to prevent cloud edge channel blocking.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In security perspective, the expectation is that users at edge environment are trusted already? in other words, do we need to consider any security protection for this data writing API exposed by edgenode? because, using k8s API and CRD case, the application is authorized to call the API for this CRD, i think. that said there is at least one security barrier to manage and write the data to the device. just wondering if we need to think any kind of this barrier at edge.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. The question you mentioned makes sense, and there should indeed be some security when sending device write requests. But I also want to point out that mapper is ultimately deployed in the cluster in the form of a pod. In order to facilitate understanding in the proposal, I directly use nodeport to expose services. Users can choose other safe ways in kubernetes to expose services when using it. For example, they can forward routes in the form of Ingress, allowing only safe traffic to arrive, or choose to only allow requests to be sent within the cluster.
Of course, what you put forward is also a good suggestion. I also add security improvement to the proposal as a feature to be considered for improvement in the next version. :)

Copy link
Copy Markdown
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this proposal has been completed, please remove the WIP label.

@wbc6080 wbc6080 force-pushed the device-writing-proposal branch from 1c08616 to 80f5e17 Compare October 16, 2024 01:42
Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
@wbc6080 wbc6080 force-pushed the device-writing-proposal branch from 80f5e17 to be72669 Compare October 16, 2024 01:43
Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
@wbc6080 wbc6080 changed the title [WIP]Add mapper support device data writing proposal Add mapper support device data writing proposal Oct 16, 2024
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@wbc6080
Copy link
Copy Markdown
Collaborator Author

wbc6080 commented Oct 16, 2024

If this proposal has been completed, please remove the WIP label.

Done. Ready to be reviewed

Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@kubeedge-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@kubeedge-bot kubeedge-bot merged commit a8192dd into kubeedge:master Oct 18, 2024
@wbc6080 wbc6080 deleted the device-writing-proposal branch October 18, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants