Skip to content

Proposal: support edge nodes report events#5722

Merged
kubeedge-bot merged 2 commits into
kubeedge:masterfrom
llmmqq8023:support-edge-nodes-report-events-proposal
Oct 17, 2024
Merged

Proposal: support edge nodes report events#5722
kubeedge-bot merged 2 commits into
kubeedge:masterfrom
llmmqq8023:support-edge-nodes-report-events-proposal

Conversation

@llmmqq8023

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind design

What this PR does / why we need it:

Proposal: support edge nodes report events

issue: #5595

@kubeedge-bot kubeedge-bot added the kind/design Categorizes issue or PR as related to design. label Jul 12, 2024
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

Welcome @llmmqq8023! It looks like this is your first PR to kubeedge/kubeedge 🎉

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2024

@Shelley-BaoYue Shelley-BaoYue left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me : )
Please add a head at the top of proposal file, format like:

---
title: xxx
authors:
- "@xxx"
  approvers: 
  creation-date: 2024-07-12
  last-updated: 2024-07-12
  status: implementable
---

@Shelley-BaoYue Shelley-BaoYue added this to the v1.19 milestone Jul 30, 2024
@llmmqq8023 llmmqq8023 force-pushed the support-edge-nodes-report-events-proposal branch from ea70afa to 6ea1674 Compare August 20, 2024 10:28
@llmmqq8023

Copy link
Copy Markdown
Contributor Author

/assign @daixiang0

@Shelley-BaoYue Shelley-BaoYue left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit name is used to let others to known what work has done in this commit. You can just squash these two commit to one, or name the second commit with add title for event report proposal
image

@llmmqq8023 llmmqq8023 force-pushed the support-edge-nodes-report-events-proposal branch from 5f603cb to cfb35c7 Compare August 29, 2024 07:43
Signed-off-by: llmmqq8023 <273337875@qq.com>

OK, I added a title.

Signed-off-by: llmmqq8023 <273337875@qq.com>

proposal for "supporting edge nodes report events"

Signed-off-by: llmmqq8023 <273337875@qq.com>
@llmmqq8023 llmmqq8023 force-pushed the support-edge-nodes-report-events-proposal branch from cfb35c7 to 448f1e1 Compare August 29, 2024 07:46
1. Pod Lifecycle Event Generator (PLEG), which is deployed in Kubelet, generates an event, and then the EventBridge API implemented in metaclient is called to report this event to the cloud.
2. Metaclient wraps this event into beehive message and puts it into the specific beehive channel.
3. Metamanager grabs the event message and give it to processEvent handler.
4. The event is stored in the edge (optional).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llmmqq8023 Maybe it's not necessary to store the message in metamanager, we don't need provide the option.

  1. Based on the functional responsibilities of edged, any module of EdgeD won't attempt to retrieve events.
  2. The loss of events doesn't significantly impact the overall system availability, meanwhile there are still log file retained.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's not stored in db :)

@fisherxu fisherxu closed this Oct 9, 2024
@fisherxu fisherxu reopened this Oct 9, 2024

@fisherxu fisherxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config field SendEvent or ReportEvent should be added to the proposal :)

Signed-off-by: llmmqq8023 <273337875@qq.com>

@fisherxu fisherxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
@kubeedge-bot kubeedge-bot merged commit 6aba118 into kubeedge:master Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants