Skip to content

OTA(Over-The-Air) Upgrades For Edge Node#5863

Merged
kubeedge-bot merged 2 commits intokubeedge:masterfrom
Believeht029:master
Oct 25, 2024
Merged

OTA(Over-The-Air) Upgrades For Edge Node#5863
kubeedge-bot merged 2 commits intokubeedge:masterfrom
Believeht029:master

Conversation

@Believeht029
Copy link
Copy Markdown
Contributor

@Believeht029 Believeht029 commented Sep 18, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
In order to make the edge node more convenient and rapid upgrade, we introduce a remote upgrade scheme OTA (Over-The-Air) into KubeEdge. In the main process of OTA(i.e. make the bundle, download the bundle, verify the bundle and firmware upgrade), we have realized most steps. Our release will generate a new image version called installation-package, then we use the NodeUpgradeJob CRD to obtain the installation tool keadm in the image and run the command to upgrade the edge node. During this process, if the hacker masquerades the image in the edge node, this will result in the untrusted binary keadm. We need to verify the digest of the image before the keadm executes the upgrade, which is the third step of OTA to verify the bundle. And in some business scenarios (Internet of vehicles, Internet of Things), we also need to provide an option to make the node wait for confirmation from a person with permission before upgrading the edge node.
Which issue(s) this PR fixes:

Fixes #5589

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 18, 2024
@kubeedge-bot kubeedge-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2024
@Shelley-BaoYue Shelley-BaoYue added this to the v1.19 milestone Sep 19, 2024
@WillardHu WillardHu closed this Sep 25, 2024
@kubeedge-bot kubeedge-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@WillardHu WillardHu reopened this Sep 25, 2024
@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
wbc6080
wbc6080 reviewed Oct 14, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the verify CI check pass. You can refer to https://kubeedge.io/docs/developer/make_verify

@wbc6080
Copy link
Copy Markdown
Collaborator

wbc6080 commented Oct 14, 2024

Please fill in the What this PR does / why we need it field in detail.
image

@Believeht029
Copy link
Copy Markdown
Contributor Author

Believeht029 commented Oct 14, 2024

I have run make_verify,but it is still failed. @wbc6080

wbc6080
wbc6080 reviewed Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the prompts to check the corresponding file code normative issues.
image

Shelley-BaoYue
Shelley-BaoYue reviewed Oct 22, 2024
View reviewed changes
wbc6080
wbc6080 reviewed Oct 23, 2024
View reviewed changes
wbc6080
wbc6080 reviewed Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash some commits https://kubeedge.io/docs/developer/Supplemental_developer_guide#ensuring-to-squash-similiar-commits

@Believeht029 Believeht029 requested a review from wbc6080 October 24, 2024 02:21
fisherxu
fisherxu reviewed Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the PR ready for review? Since it still has the WIP label :) @HT0403 @WillardHu

@Believeht029
OTA upgrade for edge node
93f62dc 
Signed-off-by: HT0403 <ht000229@qq.com>
@Believeht029 Believeht029 changed the title WIP:OTA(Over-The-Air) Upgrades For Edge Node OTA(Over-The-Air) Upgrades For Edge Node Oct 24, 2024
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@Believeht029
Copy link
Copy Markdown
Contributor Author

Believeht029 commented Oct 24, 2024

This PR is ready for review, I remove the WIP label, PTA @fisherxu @wbc6080 @WillardHu

fisherxu
fisherxu reviewed Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks!

@Believeht029
change prompt
f1daff8 
Signed-off-by: HT0403 <ht000229@qq.com>
fisherxu
fisherxu reviewed Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Looks good for the first version!

@kubeedge-bot
Copy link
Copy Markdown
Collaborator

kubeedge-bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@WillardHu
Copy link
Copy Markdown
Collaborator

WillardHu commented Oct 25, 2024

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kubeedge-bot kubeedge-bot merged commit 539ec3d into kubeedge:master Oct 25, 2024
This was referenced Apr 17, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisherxu fisherxu fisherxu left review comments

@subpathdev subpathdev Awaiting requested review from subpathdev

@Shelley-BaoYue Shelley-BaoYue Awaiting requested review from Shelley-BaoYue

@wbc6080 wbc6080 Awaiting requested review from wbc6080

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

[OSPP] OTA(Over-The-Air) Upgrades For Edge Node

6 participants

@Believeht029 @wbc6080 @kubeedge-bot @WillardHu @fisherxu @Shelley-BaoYue