Skip to content

batch process node#5968

Merged
kubeedge-bot merged 1 commit into
kubeedge:masterfrom
tangming1996:feature/batch-process-node
Jan 16, 2025
Merged

batch process node#5968
kubeedge-bot merged 1 commit into
kubeedge:masterfrom
tangming1996:feature/batch-process-node

Conversation

@tangming1996

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Enhance the batch-join command
We have just implemented a Bate version of the keadm batchjoin command to batch join edge nodes.

issue: #5590
proposal: https://github.com/kubeedge/kubeedge/blob/master/docs/proposals/batch-node-access.md
pr: #5889
Supprots login to edge nodes with the SSH private key
Currently, we implement SSH sign in to the node with username / password, but many scenarios use a private key to SSH sign in to the node, so we need to provide this method.

Supprots scp some files to edge nodes
Currently, each managed node needs to re-download the installation packages from Internet, which increases the risk of failure, and many users are offline. Therefore, we need to provide scp to transfer files from the management node to the managed nodes.
Which issue(s) this PR fixes:

Fixes #5940

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2024
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch 7 times, most recently from ecc3ae7 to 0d3de05 Compare November 18, 2024 02:58
@fisherxu fisherxu added this to the v1.20 milestone Nov 18, 2024
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch from 0d3de05 to 7cebd77 Compare November 19, 2024 03:44
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch 2 times, most recently from df37cae to 59e7419 Compare November 21, 2024 07:32
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess_genconfig.go Outdated
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go Outdated
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess_genconfig.go Outdated
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch 2 times, most recently from 7e7a27e to e3267bc Compare November 25, 2024 09:19
@tangming1996

Copy link
Copy Markdown
Contributor Author

add proposal: #5988

Comment thread keadm/cmd/keadm/app/cmd/common/types.go Outdated
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go Outdated
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch from e3267bc to 35ec123 Compare December 6, 2024 06:56
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go Outdated
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go
Comment thread keadm/cmd/keadm/app/cmd/edge/batchprocess.go
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch from 35ec123 to c4230b1 Compare December 23, 2024 08:12
@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
Comment thread keadm/cmd/keadm/app/cmd/edge/batch.go Outdated
Comment thread keadm/cmd/keadm/app/cmd/edge/batch.go Outdated
Comment thread keadm/cmd/keadm/app/cmd/edge/batch.go Outdated
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch 2 times, most recently from 2aa4cc0 to 612f937 Compare January 7, 2025 08:50
Comment thread keadm/cmd/keadm/app/cmd/edge/batch_genconfig.go Outdated
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch from 612f937 to 8067e99 Compare January 7, 2025 10:07
Signed-off-by: ming.tang <ming.tang@daocloud.io>
@tangming1996
tangming1996 force-pushed the feature/batch-process-node branch from 8067e99 to 0ac3f14 Compare January 8, 2025 02:06
@WillardHu

Copy link
Copy Markdown
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@tangming1996

Copy link
Copy Markdown
Contributor Author

@Shelley-BaoYue @fisherxu CC

Comment thread keadm/cmd/keadm/app/cmd/edge/batch.go

@fisherxu fisherxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@kubeedge-bot
kubeedge-bot merged commit 46b111d into kubeedge:master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EPIC] Enhance the keadm edge commands

7 participants