Skip to content

add batch node process proposal#5988

Merged
kubeedge-bot merged 1 commit intokubeedge:masterfrom
tangming1996:doc/batch-node-process
Jan 16, 2025
Merged

add batch node process proposal#5988
kubeedge-bot merged 1 commit intokubeedge:masterfrom
tangming1996:doc/batch-node-process

Conversation

@tangming1996
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
add batch node process proposal
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 26, 2024
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 4ea3294 to 416a89b Compare November 26, 2024 03:25
@tangming1996 tangming1996 mentioned this pull request Nov 26, 2024
@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 416a89b to 6c43715 Compare November 26, 2024 06:10
@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 6c43715 to b2a2ac0 Compare November 26, 2024 09:59
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangming1996 thank you very much for sharing this proposal. this is gonna be great feature to manage edge nodes.

i got several comments though, could you share your thoughts?

@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from b2a2ac0 to d2086a5 Compare December 16, 2024 03:09
@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch 3 times, most recently from caeb7d5 to 39dbc49 Compare December 23, 2024 09:49
@wbc6080
Copy link
Copy Markdown
Collaborator

wbc6080 commented Jan 6, 2025

Plz rebase the lastest code to pass the CI checks.

@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 39dbc49 to 1a2b043 Compare January 9, 2025 07:19
@Shelley-BaoYue Shelley-BaoYue added this to the v1.20 milestone Jan 14, 2025
Copy link
Copy Markdown
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @WillardHu @fisherxu

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) We have already merged a proposal for nodes batch join, so we should mark it as deprecated :)

ref: https://github.com/kubeedge/kubeedge/blob/master/docs/proposals/batch-node-access.md

@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 1a2b043 to 5d667e9 Compare January 14, 2025 09:25
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 5d667e9 to 1ab0623 Compare January 14, 2025 09:28
Signed-off-by: ming.tang <ming.tang@daocloud.io>
@tangming1996 tangming1996 force-pushed the doc/batch-node-process branch from 1ab0623 to 971a933 Compare January 14, 2025 09:30
@tangming1996
Copy link
Copy Markdown
Contributor Author

Looks good :) We have already merged a proposal for nodes batch join, so we should mark it as deprecated :)

ref: https://github.com/kubeedge/kubeedge/blob/master/docs/proposals/batch-node-access.md

Done!

Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @WillardHu @Shelley-BaoYue

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
Copy link
Copy Markdown
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shelley-BaoYue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@kubeedge-bot kubeedge-bot merged commit 7309dcb into kubeedge:master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants