This pr fixes Kubeedge Installer to support Centos #721

congfairy · 2019-06-19T07:45:12Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Kubeedge Installer to support Centos
Which issue(s) this PR fixes:
This pr fixes Kubeedge Installer to support Centos #454

Installation steps
Cloud:

git clone git@github.com:congfairy/kubeedge.git $GOPATH/src/github.com/kubeedge/kubeedge
cd $GOPATH/src/github.com/kubeedge/kubeedge/keadm
./kubeedge init
kubectl apply -f https://raw.githubusercontent.com/coreos/flannel/master/Documentation/kube-flannel.yml

Edge:

git clone git@github.com:congfairy/kubeedge.git $GOPATH/src/github.com/kubeedge/kubeedge
Manually copy certs.tgz from cloud host to edge host(s)
On edge host: mkdir -p /etc/kubeedge
On cloud host: cd /etc/kubeedge/
scp -r certs.tgz username@ipEdgevm:/etc/kubeedge
On edge host untar the certs.tgz file: cd /etc/kubeedge
tar -xvzf certs.tgz
3./kubeedge join --edgecontrollerip=xxxx --edgenodeid=testing123 --k8sserverip=xxxx:8080

Here are the console output:
Cloud : After kubeedge init

Edge:

On the cloud,kubectl get nodes:

subpathdev · 2019-06-19T09:11:22Z

please remove keadm/log

for centos kubeedge installer ready cloud ready edgecore ready cloud with device model error edgecontroller ready cloud and edge are ready update wget everything ok kubeedge centos installer works delete log

kevin-wangzefeng · 2019-06-19T09:15:43Z

The author info in commit history is not correct. Please fix it. You may follow this instruction

/assign @sids-b

subpathdev · 2019-06-19T09:22:42Z

to address the previous commit you can actual use this command:

git rebase -i HEAD~3

HEAD~3 means you will use the 4th last commit as rebase base

samy2019 · 2019-06-19T09:40:27Z

keadm/app/cmd/util/centosinstaller.go

+
+	//Install docker-ce
+	fmt.Println("stdout is %s", stdout)
+	dockerInst := fmt.Sprintf("sudo yum install -y  --skip-broken docker-ce-%s", stdout)


Please take care of downgrade and "--allow-change-held-packages" apt-get flag equivalent in yum

@congfairy , have you taken care of this ?

samy2019 · 2019-06-19T09:41:22Z

keadm/app/cmd/util/centosinstaller.go

 	// yum install -y yum-utils
-	// yum-config-manager --add-repo https://download.docker.com/linux/centos/docker-ce.repo
+	//yum-config-manager --add-repo https://download.docker.com/linux/centos/docker-ce.repo
+	//	yum-config-manager --add-repo /etc/yum.repos.d/docker.repo
 	// yum makecache


Remove these comments

samy2019 · 2019-06-19T09:45:45Z

keadm/app/cmd/util/centosinstaller.go

+func (c *CentOS) addK8SRepositoryAndUpdate() error {
+	//Get the distribution version
+	// cmd := &Command{Cmd: exec.Command("sh", "-c", "lsb_release -cs")}
+	// cmd.ExecuteCommand()


Remove all commented code

samy2019 · 2019-06-19T09:49:40Z

keadm/app/cmd/util/centosinstaller.go

+	cmd := &Command{Cmd: exec.Command("sh", "-c", updtRepo)}
+	cmd.ExecuteCommand()
+	updtRepoErr := cmd.GetStdErr()
+	fmt.Printf("updtRepoErr %s", updtRepoErr)


You don't need to print incase there is no error. Hence remove this print

samy2019 · 2019-06-19T09:50:27Z

keadm/app/cmd/util/centosinstaller.go

+	fmt.Println("Expected K8S('", k8sComponent, "') version to install is", stdout)
+
+	//Install respective K8S components based on where it is being installed
+	k8sInst := fmt.Sprintf("yum install -y kubeadm-%s kubelet-%s kubectl-%s --disableexcludes=kubernetes", stdout, stdout, stdout)


Please take care of downgrade and "--allow-change-held-packages" apt-get flag equivalent in yum

samy2019 · 2019-06-19T10:06:08Z

keadm/app/cmd/util/cloudinstaller.go

 	if err != nil {
 		return err
 	}
+	time.Sleep(5 * time.Second)


Is this sleep very much necessary? If not, please remove, or else check if you can reduce it to 1 second.

samy2019 · 2019-06-19T10:06:49Z

keadm/app/cmd/util/cloudinstaller.go

@@ -50,6 +55,11 @@ func (cu *KubeCloudInstTool) InstallTools() error {
 	if err != nil {
 		return err
 	}
+	time.Sleep(5 * time.Second)


I don't think this sleep is required. Please remove.

samy2019 · 2019-06-19T10:14:08Z

keadm/app/cmd/util/cloudinstaller.go

 	fmt.Println("Edgecontroller started")

 	return nil
 }

+//create device model and device CRDS
+func (cu *KubeCloudInstTool) createdevicemodel() error {
+	cmdf := fmt.Sprintf("kubectl create -f $GOPATH/src/github.com/kubeedge/kubeedge/build/crds/devices/devices_v1alpha1_devicemodel.yaml")


Both kubectl commands will not work if KubeEdge code is not cloned already. keadm init will simply download binaries and not these crd file. Please fix this approach.
Possibly you might have to download only these files in /etc/kubeedge/cloud/conf/ path and in kubectl command access this path to create crd files.

Do you mean in createdevicemodel function we download devices_v1alpha1_devicemodel.yaml file to /etc/kubeedge/cloud/conf directory firstly and then kubectl create?

@congfairy: yes do wget on devices_v1alpha1_devicemodel.yaml and instance.yaml file from source code in /etc/kubeedge/cloud/conf..
Then u can do kubectl apply....

samy2019 · 2019-06-19T10:16:53Z

keadm/app/cmd/util/common.go

-	KubernetesGPGURL      = "https://packages.cloud.google.com/apt/doc/apt-key.gpg"
-
+	KubernetesDownloadURL     = "https://apt.kubernetes.io/"
+	KubernetesGPGURL          = "https://packages.cloud.google.com/apt/doc/apt-key.gpg"


Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used.

samy2019 · 2019-06-19T10:17:47Z

keadm/app/cmd/util/common.go

+	KubernetesDownloadURL     = "https://apt.kubernetes.io/"
+	KubernetesGPGURL          = "https://packages.cloud.google.com/apt/doc/apt-key.gpg"
+	KubernetesBaseurl         = "https://packages.cloud.google.com/yum/repos/kubernetes-el7-x86_64"
+	KubernetesGpgkey          = "https://packages.cloud.google.com/yum/doc/yum-key.gpg https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg"


Rename this as KubernetesGpgkey - >KubernetesCentOSGPGKey , Modify it where ever it is used.

samy2019 · 2019-06-19T11:38:18Z

@congfairy , Please share your test results as well. I mean the console output after executing "keadm init" in master node and "keadm join" in worker node. Also show proof, if you have deployed deployment pods, secrets and configmap.

kubeedge-bot · 2019-06-20T00:48:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sids-b

If they are not already assigned, you can assign the PR to them by writing /assign @sids-b in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

congfairy · 2019-06-21T01:30:59Z

@congfairy , Please share your test results as well. I mean the console output after executing "keadm init" in master node and "keadm join" in worker node. Also show proof, if you have deployed deployment pods, secrets and configmap.

@samy2019 Yes, I have updated that.

rohitsardesai83 · 2019-06-26T10:26:54Z

keadm/app/cmd/util/cloudinstaller.go

-		return fmt.Errorf("%s", errout)
+	err := cmd.StartCmd()
+	if err != nil {
+		fmt.Println("in error")


can we log the error ? also can we shift to using log package instead of fmt for all logging ?

srivatsav123 · 2019-07-02T10:34:09Z

keadm/app/cmd/util/centosinstaller.go

+		return fmt.Errorf("%s", errout)
+	}
+	fmt.Println(cmd.GetStdOutput())
+


Please remove space

srivatsav123 · 2019-07-02T10:42:34Z

keadm/app/cmd/util/centosinstaller.go

+		install = false
+	}
+	if install == true {
+		cmd := &Command{Cmd: exec.Command("sh", "-c", "swapoff -a && kubeadm init --pod-network-cidr 10.244.0.0/16")}


@congfairy what if , User wants to use calico ,weaver or diffferent Overlay network...It will be better if we dynamically provision which overlay network user wants to use?

srivatsav123 · 2019-07-02T10:49:30Z

keadm/app/cmd/util/cloudinstaller.go

 	fmt.Println("Edgecontroller started")

 	return nil
 }

+//create device model and device CRDS
+func (cu *KubeCloudInstTool) createdevicemodel() error {
+	cmdf := fmt.Sprintf("kubectl create -f $GOPATH/src/github.com/kubeedge/kubeedge/build/crds/devices/devices_v1alpha1_devicemodel.yaml")


@congfairy: yes do wget on devices_v1alpha1_devicemodel.yaml and instance.yaml file from source code in /etc/kubeedge/cloud/conf..
Then u can do kubectl apply....

srivatsav123 · 2019-07-02T10:51:28Z

keadm/app/cmd/util/centosinstaller.go

+	}
+
+	fmt.Println("Expected K8S('", k8sComponent, "') version to install is", stdout)
+


Please remove extra space .Its applicable everywhere

sids-b · 2019-07-11T05:12:10Z

@congfairy , please resolve the conflicts... The PR looks good to me :)

congfairy · 2019-07-11T07:41:28Z

@congfairy , please resolve the conflicts... The PR looks good to me :)
@srivatsav123 @sids-b
Hi,

could you help me to explain how could I resolve the conflicts?
Also ,there is some problem with the code .I would like to transfer the --pod-network-cidr as the parameter for kubeedge init,(then after kubeedge started,users could select to apply flannel or calico yaml file), but it seems that StartK8Scluster function in centosinstaller.go file couldn't get the parameter,could you help me to check the problem ?Appreciate.

srivatsav123 · 2019-07-11T10:12:15Z

@congfairy

For 1 st issue you can refer below you tube video to resolve merge conflicts
https://www.youtube.com/watch?v=1MVQYSlgXrI
2.for 2 nd issue, i have shared the below code..Please change it and test it once..

congfairy · 2019-07-12T06:24:01Z

@srivatsav123
This is the remote configuration:

I have try to solve the conflict by:

git fetch upstream
git merge origin/keadm-claire
git push origin keadm-claire
And it outputs that Everything up-to-date
it seems that I haven't solved the conflicts,is there something wrong?Thanks.
Also,could you show me the github address for your code?And when user choose "flannel" as the PodNetwork,where chould they define the cidr?
Thanks!

rohitsardesai83 · 2019-07-15T11:02:39Z

@srivatsav123
This is the remote configuration:

I have try to solve the conflict by:

1. git fetch upstream

2. git merge origin/keadm-claire

3. git push origin keadm-claire
   And it outputs that Everything up-to-date
   it seems that I haven't solved the conflicts,is there something wrong?Thanks.
   Also,could you show me the github address for your code?And when user choose "flannel" as the PodNetwork,where chould they define the cidr?
   Thanks!

@congfairy , can you please try :
git fetch upstream
git rebase upstream/master

FengyunPan2 · 2020-03-10T02:13:06Z

Is the thing going?

fisherxu · 2020-03-10T03:38:33Z

Is the thing going?

Looks like it's been hanging for a long time, and are you interested in fixing it based on the new keadm code? @FengyunPan2

FengyunPan2 · 2020-03-10T04:43:54Z

@fisherxu Yes, I want to deploy kubeedge on Centos. After getting so many errors by keadm, I find this PR which is handing. Now I have deployed kubeedge on Centos by shell script.
BTW, if @congfairy doesn't mind, I can do it.

fisherxu · 2020-03-10T06:24:38Z

After getting so many errors by keadm, I find this PR which is handing.

Now the keadm still doesn't support centos, most func still leave empty... I think you can try it, and now keadm don't install k8s/runtime, so we only need implement the kubeedge related funcs. :)

FengyunPan2 · 2020-03-10T12:30:22Z

PTAL: #1536

kevin-wangzefeng · 2020-03-18T07:13:00Z

closing as #1536 is merged
/close

kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2019

kubeedge-bot requested review from CindyXing and kevin-wangzefeng June 19, 2019 07:45

kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 19, 2019

congfairy changed the title ~~Keadm claire~~ This pr fixes Kubeedge Installer to support Centos #454 Jun 19, 2019

kevin-wangzefeng changed the title ~~This pr fixes Kubeedge Installer to support Centos #454~~ This pr fixes Kubeedge Installer to support Centos Jun 19, 2019

kubeedge installer for centos,squash the previous commit

e110aa6

for centos kubeedge installer ready cloud ready edgecore ready cloud with device model error edgecontroller ready cloud and edge are ready update wget everything ok kubeedge centos installer works delete log

kubeedge-bot assigned sids-b Jun 19, 2019

samy2019 reviewed Jun 19, 2019

View reviewed changes

congfairy force-pushed the keadm-claire branch from dc154a9 to e110aa6 Compare June 20, 2019 00:47

remove comments

f890e4b

kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 21, 2019

rohitsardesai83 added this to the Backlog milestone Jun 24, 2019

rohitsardesai83 reviewed Jun 26, 2019

View reviewed changes

srivatsav123 suggested changes Jul 2, 2019

View reviewed changes

modify cidr

298f8e9

kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2019

add --pod-network-cidr

d35a91f

sids-b mentioned this pull request Sep 16, 2019

centosinstaller need to implement #1121

Closed

kevin-wangzefeng closed this Mar 18, 2020

		}

		fmt.Println("Expected K8S('", k8sComponent, "') version to install is", stdout)

This pr fixes Kubeedge Installer to support Centos #721

This pr fixes Kubeedge Installer to support Centos #721

Conversation

congfairy commented Jun 19, 2019 • edited

subpathdev commented Jun 19, 2019

kevin-wangzefeng commented Jun 19, 2019

subpathdev commented Jun 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samy2019 commented Jun 19, 2019

kubeedge-bot commented Jun 20, 2019

congfairy commented Jun 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sids-b commented Jul 11, 2019

congfairy commented Jul 11, 2019

srivatsav123 commented Jul 11, 2019

congfairy commented Jul 12, 2019 • edited

rohitsardesai83 commented Jul 15, 2019

FengyunPan2 commented Mar 10, 2020

fisherxu commented Mar 10, 2020

FengyunPan2 commented Mar 10, 2020

fisherxu commented Mar 10, 2020

FengyunPan2 commented Mar 10, 2020 • edited

kevin-wangzefeng commented Mar 18, 2020

congfairy commented Jun 19, 2019 •

edited

congfairy commented Jul 12, 2019 •

edited

FengyunPan2 commented Mar 10, 2020 •

edited