feat: block member label modification through DP #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR blocks direct modification of fleet member cluster labels through the dataplane unless performed by the RP client.
- Introduces a new constant and check in the user validation logic to deny label modifications by non-RP clients.
- Adds the helper function isRPClient to identify RP clients based on username and group membership.
- Updates the webhook test suite to verify that label modifications are allowed for RP clients and denied for non-RP clients.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/webhook/validation/uservalidation.go | Adds constant and logic to deny label modifications by non-RP clients along with a new isRPClient helper function. |
| pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook_test.go | Adds test cases to verify the new label modification restrictions. |
zhiying-lin
reviewed
Apr 30, 2025
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook_test.go
Outdated
Show resolved
Hide resolved
jwtty
reviewed
Apr 30, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
audrastump
force-pushed
the
main
branch
3 times, most recently
from
c86ddf2 to
4579fb3
Compare
Signed-off-by: audrastump <a.e.stump@wustl.edu>
audrastump
force-pushed
the
main
branch
2 times, most recently
from
674fee6 to
cb856d4
Compare
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
jim-minter
reviewed
May 8, 2025
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
jim-minter
reviewed
May 9, 2025
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Signed-off-by: audrastump <a.e.stump@wustl.edu>
britaniar
reviewed
May 9, 2025
jwtty
reviewed
May 14, 2025
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook_test.go
Outdated
Show resolved
Hide resolved
jwtty
requested changes
May 14, 2025
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook_test.go
Outdated
Show resolved
Hide resolved
jwtty
requested changes
May 14, 2025
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook_test.go
Outdated
Show resolved
Hide resolved
pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook_test.go
Outdated
Show resolved
Hide resolved
jwtty
reviewed
May 14, 2025
jwtty
approved these changes
May 14, 2025
Signed-off-by: audrastump <a.e.stump@wustl.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Blocking users from modifying member cluster labels directly through the dataplane unless they are the RP client. Not mergeable until member label changes are available through CLI.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Unit tests
Special notes for your reviewer