Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpi backend: master should be the last in hostfile #20

Merged

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Aug 7, 2018

It is because normal typical usecase uses only workers in distributed learning.

we keep master in hostfile just for the rare scenario which user uses all the pods (master and workers) for distributed learning.

before

Under this hostfile, master pod always attend to mpiexec. But most users want to make only workers attend to it. There is no easy way for users to exclude master in mpiexec.

(master) # cat /kubeflow/chainer-operator/generated/hostfile
example-job-mn-master-hzp66 slots=1
example-job-mn-workerset-ws0-0 slots=1
example-job-mn-workerset-ws1-0 slots=1

after

This is easier for users. user can do in both cases by adjusting mpiexec parameters. With -n 2, only workers will attend to distributed learning. With -n 3, all the pods(master and workers) will attend to it.

(master) # cat /kubeflow/chainer-operator/generated/hostfile
example-job-mn-workerset-ws0-0 slots=1
example-job-mn-workerset-ws1-0 slots=1
example-job-mn-master-hzp66 slots=1

This change is Reviewable

because normal usecase uses workers only for distributed learning.

we keep master in hostlist just for the senario which user uses master
for distributed learning.
@everpeace
Copy link
Contributor Author

@disktnk could you review this?

@disktnk
Copy link
Member

disktnk commented Aug 7, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disktnk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e7c3867 into kubeflow:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants