Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

optimize the ttl of job #137

Merged
merged 2 commits into from Jun 29, 2021
Merged

optimize the ttl of job #137

merged 2 commits into from Jun 29, 2021

Conversation

HeGaoYuan
Copy link
Contributor

@HeGaoYuan HeGaoYuan commented Jun 26, 2021

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@@ -45,32 +45,6 @@ func (jc *JobController) DeletePodsAndServices(runPolicy *apiv1.RunPolicy, job i
return nil
}

func (jc *JobController) cleanupJobIfTTL(runPolicy *apiv1.RunPolicy, jobStatus apiv1.JobStatus, job interface{}) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which code is referencing this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge I don't find any code is referencing the cleanupJobIfTTL function. And I found that the cleanupJobIfTTL function is same with the CleanupJob function( before I edit), so I removed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it seems that the func is not used now.

@johnugeorge
Copy link
Member

/lgtm

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 5a4f6c5 into kubeflow:master Jun 29, 2021
@HeGaoYuan
Copy link
Contributor Author

@terrytangyuan @gaocegege
But I left a todo: Is the jobStatus.CompletionTime maybe nil ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants