optimize the ttl of job#137
Conversation
gaocegege
left a comment
gaocegege
left a comment
There was a problem hiding this comment.
/assign @Jeffwan @johnugeorge
|
Thanks for your contribution! 🎉 👍 |
| return nil | ||
| } | ||
|
|
||
| func (jc *JobController) cleanupJobIfTTL(runPolicy *apiv1.RunPolicy, jobStatus apiv1.JobStatus, job interface{}) error { |
There was a problem hiding this comment.
Which code is referencing this function?
There was a problem hiding this comment.
@johnugeorge I don't find any code is referencing the cleanupJobIfTTL function. And I found that the cleanupJobIfTTL function is same with the CleanupJob function( before I edit), so I removed it.
There was a problem hiding this comment.
LGTM, it seems that the func is not used now.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@terrytangyuan @gaocegege |
6 participants
my implementation refer to
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/ttlafterfinished/ttlafterfinished_controller.go#L290