This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Fix exitCode check #190
Merged
Fix exitCode check #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah sorry there was a markdown formatting error. Fixed now |
|
Can you rebase this PR as well? |
1 similar comment
|
Can you rebase this PR as well? |
The exitCode check works differently then described in the API: https://github.com/kubeflow/common/blob/master/pkg/apis/common/v1/types.go\#L163-L168 In addition the document exitCodes for Docker will not appear in a Kubernetes pod status (anymore?)
|
@johnugeorge done |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
djwhatle
pushed a commit
to djwhatle/common
that referenced
this pull request
Jul 26, 2022
The exitCode check works differently then described in the API: https://github.com/kubeflow/common/blob/master/pkg/apis/common/v1/types.go\#L163-L168 In addition the document exitCodes for Docker will not appear in a Kubernetes pod status (anymore?) (cherry picked from commit 21f5ba8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exitCode check works differently then described in the API
In addition the document exitCodes for Docker will not appear in a Kubernetes pod status (anymore?)