Only use secure transport mode for new Azure Storage Accounts#477
Only use secure transport mode for new Azure Storage Accounts#477k8s-ci-robot merged 1 commit intokubeflow:masterfrom
Conversation
|
Hi @berndverst. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@jinchihe any update? :) |
|
/lgtm Thanks @berndverst |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinchihe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently Fairing creates new Storage Accounts on Azure (if necessary) that do not use best practices of enabling strict transport security. Azure Security Center will flag these storage accounts.
This PR uses the recommended default (which unfortunately isn't the default in the Python SDK).
References:
https://github.com/Azure-Samples/storage-python-manage#create-account
https://docs.microsoft.com/en-us/azure/storage/common/storage-require-secure-transfer
https://docs.microsoft.com/en-us/python/api/azure-mgmt-storage/azure.mgmt.storage.v2018_07_01.models.storageaccountcreateparameters?view=azure-python
Release note:
-->
This change is