Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Only use secure transport mode for new Azure Storage Accounts #477

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

berndverst
Copy link
Member

@berndverst berndverst commented Mar 11, 2020

What this PR does / why we need it:

Currently Fairing creates new Storage Accounts on Azure (if necessary) that do not use best practices of enabling strict transport security. Azure Security Center will flag these storage accounts.

This PR uses the recommended default (which unfortunately isn't the default in the Python SDK).

References:
https://github.com/Azure-Samples/storage-python-manage#create-account
https://docs.microsoft.com/en-us/azure/storage/common/storage-require-secure-transfer
https://docs.microsoft.com/en-us/python/api/azure-mgmt-storage/azure.mgmt.storage.v2018_07_01.models.storageaccountcreateparameters?view=azure-python

Release note:
-->

NONE

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @berndverst. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinchihe
Copy link
Member

/ok-to-test

@berndverst
Copy link
Member Author

@jinchihe any update? :)

@jinchihe
Copy link
Member

/lgtm
/approve

Thanks @berndverst

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1345f55 into kubeflow:master Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants