Implement validation for early stopping

[tenzen-y]

What this PR does / why we need it:

Users can not find the wrong algorithm name until to start trial Pod since there are no validating webhooks for early stopping. So, implement validating webhooks for spec.earlyStopping.algorithmName.
Also, I implement gRPC API to verify parameters for early stopping so that it can verify parameters.
In addition, I fix some documentations.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1680

/assign
/assign @andreyvelich @gaocegege @johnugeorge

[andreyvelich]

Thank you so much for driving this @tenzen-y!
I left my questions.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tenzen-y
To complete the pull request process, please ask for approval from andreyvelich after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Coverage increased (+0.5%) to 74.214% when pulling 6f231e8 on tenzen-y:issue-1680-implement-validating-webhook-for-early-stopping into cffab07 on kubeflow:master.

[tenzen-y]

Can you comment with @googlebot I consent., please? @andreyvelich

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[andreyvelich]

@googlebot I consent.

[tenzen-y]

I addressed all your suggestions.
Can you re-check the changes? @andreyvelich

[andreyvelich]

Thank you for the updates @tenzen-y!
/lgtm
/assign @gaocegege @johnugeorge

[tenzen-y]

Thanks for the review! @andreyvelich
According to this documentation, I'll create PR to update API documentation in kubeflow/website repository.

[andreyvelich]

Thanks for the review! @andreyvelich According to this documentation, I'll create PR to update API documentation in kubeflow/website repository.

I think API Reference page is outdated.
@tenzen-y @gaocegege @johnugeorge Do we want to maintain this API doc on the Kubeflow website ?
Since we have similar API doc here, maybe we can just add the link to this doc in Katib Interfaces section.

[tenzen-y]

Thanks for the review! @andreyvelich According to this documentation, I'll create PR to update API documentation in kubeflow/website repository.

I think API Reference page is outdated. @tenzen-y @gaocegege @johnugeorge Do we want to maintain this API doc on the Kubeflow website ? Since we have similar API doc here, maybe we can just add the link to this doc in Katib Interfaces section.

Sounds good to me.

[gaocegege]

SGTM!

Thanks for the review! @andreyvelich According to this documentation, I'll create PR to update API documentation in kubeflow/website repository.

I think API Reference page is outdated. @tenzen-y @gaocegege @johnugeorge Do we want to maintain this API doc on the Kubeflow website ? Since we have similar API doc here, maybe we can just add the link to this doc in Katib Interfaces section.

[tenzen-y]

Removed description about updating gRPC API docs in kubeflow website. @andreyvelich

[andreyvelich]

Thanks @tenzen-y!
/lgtm
/assign @gaocegege @johnugeorge

[tenzen-y]

Could you review this PR? @gaocegege @johnugeorge

[johnugeorge]

Sorry for delay
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment