New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Use multiple stage builds #23

Merged
merged 4 commits into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@gaocegege
Member

gaocegege commented Apr 9, 2018

  • Reduce the time spent on building (80% faster in China)
  • Reduce the size of the image (891 MB -> 16.7 MB (2% of the original image))

/assign @YujiOshima

gaocegege added some commits Apr 9, 2018

suggestion: Support multiple stage builds
Signed-off-by: Ce Gao <gaoce@caicloud.io>
docs: Add requiremnet for docker build
Signed-off-by: Ce Gao <gaoce@caicloud.io>

gaocegege added some commits Apr 9, 2018

manifests: Remove the args and use entrypoint
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Dockerfile: Replace shell format with exec format
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@YujiOshima

This comment has been minimized.

Contributor

YujiOshima commented Apr 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 9, 2018

@k8s-ci-robot

This comment has been minimized.

k8s-ci-robot commented Apr 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

k8s-ci-robot commented Apr 9, 2018

@gaocegege: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-hp-tuning-presubmit fa9fde0 link /test kubeflow-hp-tuning-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaocegege

This comment has been minimized.

Member

gaocegege commented Apr 9, 2018

The CI takes too long time thus I merged it manually first.

@gaocegege gaocegege merged commit ed0d31d into kubeflow:master Apr 9, 2018

2 of 3 checks passed

kubeflow-hp-tuning-presubmit Job failed.
Details
cla/google All necessary CLAs are signed
tide In merge pool.
Details

@gaocegege gaocegege deleted the gaocegege:dockerfile branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment