Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor webhook organization #711

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@hougangliu
Copy link
Member

commented Aug 5, 2019

Move webhook related code for katib on pkg/webhook directory, which will include webhook for experiment, Pod and Job level.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from andreyvelich and garganubhav Aug 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/L label Aug 5, 2019
@hougangliu

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@k8s-ci-robot k8s-ci-robot requested review from gaocegege and johnugeorge Aug 5, 2019
Copy link
Member

left a comment

/lgtm

@gaocegege

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

/retest

1 similar comment
@gaocegege

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

/retest

@hougangliu

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6d4dd47 into kubeflow:master Aug 5, 2019
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable.
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 58.057%
Details
kubeflow-katib-presubmit Job succeeded.
Details
wuchunghsuan added a commit to wuchunghsuan/katib that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.