Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directory structure #737

Merged
merged 2 commits into from Sep 3, 2019
Merged

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Sep 3, 2019

Directories are restructured based on #495
Changes

  1. pkg/api renamed to pkg/apis
  2. GRPC proto files moved to pkg/apis/manager
  3. k8s CRs moved to pkg/apis/controller
  4. Experiment folder renamed to Experiments
  5. Trial folderrenamed to Trials
  6. pkg/controller/v1alpha2 renamed to pkg/controller.v1alpha2

This change is Reviewable

@johnugeorge
Copy link
Member Author

@gaocegege @hougangliu Can you review the directory structure?

@hougangliu
Copy link
Member

/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks! I love the refactor.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab0b4a7 into kubeflow:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants