From 8305dcd495df1edb6ed0e53f4a67ea233bc75825 Mon Sep 17 00:00:00 2001 From: Shingo Omura Date: Thu, 19 Apr 2018 14:51:05 +0900 Subject: [PATCH] add 'schedulerName' to openmpi package. In Kubernetes default scheduler, scheduling multiple openmpi package will sometimes lead deadlocks as discussed https://github.com/kubeflow/tf-operator/issues/165 . In that case, user would want to perform gang-scheduling(scheduling a group of pods all-together). Currently, kube-arbitrator support it. To achieve that, we need to make 'schedulerName' customizable. --- kubeflow/openmpi/prototypes/openmpi.jsonnet | 1 + kubeflow/openmpi/workloads.libsonnet | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/kubeflow/openmpi/prototypes/openmpi.jsonnet b/kubeflow/openmpi/prototypes/openmpi.jsonnet index 516c310cdde..53516123649 100644 --- a/kubeflow/openmpi/prototypes/openmpi.jsonnet +++ b/kubeflow/openmpi/prototypes/openmpi.jsonnet @@ -7,6 +7,7 @@ // @param secret string Name of secret containing ssh keys. // @optionalParam namespace string null Namespace to use for the components. It is automatically inherited from the environment if not set. // @optionalParam workers number 4 Number of workers. +// @optionalParam schedulerName string default-scheduler scheduler name to use for the components. local k = import "k.libsonnet"; local openmpi = import "kubeflow/openmpi/all.libsonnet"; diff --git a/kubeflow/openmpi/workloads.libsonnet b/kubeflow/openmpi/workloads.libsonnet index a420ebed3f8..bf6769a6812 100644 --- a/kubeflow/openmpi/workloads.libsonnet +++ b/kubeflow/openmpi/workloads.libsonnet @@ -38,7 +38,7 @@ restartPolicy: "Always", terminationGracePeriodSeconds: 30, dnsPolicy: "ClusterFirst", - schedulerName: "default-scheduler", + schedulerName: params.schedulerName, volumes: [ { name: "kubeflow-openmpi-secrets",