From 982dcd4945983247eb7efc75e2175feaeeacb8f3 Mon Sep 17 00:00:00 2001 From: Holden Karau Date: Wed, 10 Oct 2018 17:51:11 +0300 Subject: [PATCH] Clarify jobName param, remove Fix this since it has been integrated into all.libsonnet as intended. --- kubeflow/spark/all.libsonnet | 1 - kubeflow/spark/prototypes/spark-job.jsonnet | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/kubeflow/spark/all.libsonnet b/kubeflow/spark/all.libsonnet index 14a89aec44a..1c1a537597c 100644 --- a/kubeflow/spark/all.libsonnet +++ b/kubeflow/spark/all.libsonnet @@ -310,7 +310,6 @@ labels: { version: sparkVersion, }, - // Fix this serviceAccount: params.name + "-spark", volumeMounts: [ { diff --git a/kubeflow/spark/prototypes/spark-job.jsonnet b/kubeflow/spark/prototypes/spark-job.jsonnet index 876316c6911..f98efd672d6 100644 --- a/kubeflow/spark/prototypes/spark-job.jsonnet +++ b/kubeflow/spark/prototypes/spark-job.jsonnet @@ -3,7 +3,7 @@ // @param name string Name for the component // @param applicationResource string jar or pyfile reference for spark-submit // @optionalParam namespace string default namespace to run in -// @optionalParam jobName string defaultjob Name for the component +// @optionalParam jobName string defaultjob Name for the job // @optionalParam mainClass string null JVM Class name of driver entry point // @optionalParam type string Scala Type of applicaiton (e.g. Scala, Python) // @optionalParam driverCores number 2 number of cores for driver