Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with std.asciiUpper with supported by required version of jsonnet #2104

Merged
merged 1 commit into from Dec 17, 2018

Conversation

@Jeffwan
Copy link
Contributor

Jeffwan commented Dec 17, 2018

Had one PR to address issue on 0.3 branch
#2073

Submit another one for master branch.


This change is Reviewable

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Dec 17, 2018

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan Jeffwan mentioned this pull request Dec 17, 2018
@Jeffwan

This comment has been minimized.

Copy link
Contributor Author

Jeffwan commented Dec 17, 2018

/assign @jlewi @r2d4

@Jeffwan

This comment has been minimized.

Copy link
Contributor Author

Jeffwan commented Dec 17, 2018

@k8s-ci-robot k8s-ci-robot requested review from jlewi and r2d4 Dec 17, 2018
@r2d4
r2d4 approved these changes Dec 17, 2018
Copy link
Member

r2d4 left a comment

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 17, 2018
@jlewi

This comment has been minimized.

Copy link
Contributor

jlewi commented Dec 17, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, r2d4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5b37f0b into kubeflow:master Dec 17, 2018
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
kubeflow-presubmit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.