Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 3857 to v0.6-branch #3884

Merged

Conversation

@yanniszark
Copy link
Contributor

yanniszark commented Aug 13, 2019

Cherry pick #3857 to v0.6-branch.
The PR #3857 renames the existing_arrikto config file to conform with the other config file names.

cc @kunmingg

/assign @gabrielwen @kkasravi


This change is Reviewable

@yanniszark

This comment has been minimized.

Copy link
Contributor Author

yanniszark commented Aug 13, 2019

/retest

@jlewi

This comment has been minimized.

Copy link
Contributor

jlewi commented Aug 13, 2019

Is this going to break people who expect the old file name on the 0.6-branch?

@yanniszark

This comment has been minimized.

Copy link
Contributor Author

yanniszark commented Aug 14, 2019

Is this going to break people who expect the old file name on the 0.6-branch?

No, the current website config URIs point to master.
Once this change is in, we will also pass a PR pointing the configs URIs to v0.6-branch.
Relevant Website PR: kubeflow/website#1071

@yanniszark

This comment has been minimized.

Copy link
Contributor Author

yanniszark commented Aug 14, 2019

/retest

@yanniszark yanniszark force-pushed the yanniszark:cherry-pick-3857-to-v0.6-branch branch 2 times, most recently from 6ac20b0 to a3e043d Aug 14, 2019
@yanniszark

This comment has been minimized.

Copy link
Contributor Author

yanniszark commented Aug 19, 2019

@gabrielwen @jlewi
Tests are passing now.
Can you please take a quick look and approve if everything is ok?
It's only a file rename.

This PR renames the existing_arrikto config file from
kfctl_existing_arrikto.0.6.yaml to kfctl_existing_arrikto.yaml, to
maintain consistency with the other config files.

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@yanniszark yanniszark force-pushed the yanniszark:cherry-pick-3857-to-v0.6-branch branch from a3e043d to 7da417a Aug 21, 2019
@gabrielwen

This comment has been minimized.

Copy link
Contributor

gabrielwen commented Aug 22, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabrielwen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cf928a0 into kubeflow:v0.6-branch Aug 22, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
kubeflow-presubmit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.