Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an Angular Library with common frontend code #5252

Conversation

kimwnasptd
Copy link
Member

@kimwnasptd kimwnasptd commented Aug 28, 2020

Create an Angular Library with common frontend code. Our crud web apps should use this library to share common functionality like:

  • Talking to Central Dashboard for the Namespace selection
  • Making http calls
  • Surfacing and showing error messages and warnings
  • Form utilities
  • Showing a table with entries and actions

This is a follow up PR from the backend code #5164

Create an Angular Library with common frontend code. Our crud web apps
should use this library to share common functionality like:

* Talking to Central Dashboard for the Namespace selection
* Making http calls
* Surfacing and showing error messages and warnings
* Form utilities
* Showing a table with entries and actions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@kimwnasptd
Copy link
Member Author

/assign @kimwnasptd

@elikatsis
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elikatsis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 523c02b into kubeflow:master Aug 28, 2020
2 of 3 checks passed
@elikatsis elikatsis deleted the feature-kimwnasptd-wa-common-frontend-code branch August 28, 2020 13:39
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Create an Angular Library with common frontend code. Our crud web apps
should use this library to share common functionality like:

* Talking to Central Dashboard for the Namespace selection
* Making http calls
* Surfacing and showing error messages and warnings
* Form utilities
* Showing a table with entries and actions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
Create an Angular Library with common frontend code. Our crud web apps
should use this library to share common functionality like:

* Talking to Central Dashboard for the Namespace selection
* Making http calls
* Surfacing and showing error messages and warnings
* Form utilities
* Showing a table with entries and actions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants