Refactor the JWA backend to utilize common code #5316
Conversation
Update the common python wheel wrt: * How to distinguish between dev and prod mode * Extra routes for handling Notebooks * Serving the index.html for every non api route (SPA) * Add a STOPPED state to the possible Status values Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
|
This change is |
* Extend the configuration yaml with default form values for the affinity/tolerations * Set them accordingly when the user submits a notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
kimwnasptd
changed the title
|
The last commit for supporting Affinity and Tolerations is there. This is ready for review |
|
|
||
|
|
||
| # helper functions | ||
| def start_stop_notebook(namespace, notebook, request_body): |
There was a problem hiding this comment.
Why does this need to be a separate function?
The patch function is sufficient?
There was a problem hiding this comment.
I was thinking that If in the future we want to handle other cases in the PATCH request, then each one of them should be its own function and not have all the logic unfolded in the PATCH handler
There was a problem hiding this comment.
I was thinking that If in the future we want to handle other cases in the PATCH request, then each one of them should be its own function and not have all the logic unfolded in the PATCH handler
|
Should we rename the |
|
This looks pretty good as a first pass (although I am still sceptical we need a fully separate code path for ROK). I assume we will implement the changes from #5280 when we make the new |
There was a problem hiding this comment.
Should we rename the /jupyter prefix on the URL to something more generic?
Was thinking of keeping it as is for now until we replace the the code entirely. Then once we have completely replaced the app we can change the naming both in the routes as well in the manifests naming.
|
I think we can move on with merging this. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elikatsis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* WA: Backend common: update the library Update the common python wheel wrt: * How to distinguish between dev and prod mode * Extra routes for handling Notebooks * Serving the index.html for every non api route (SPA) * Add a STOPPED state to the possible Status values Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * JWA: Add the refactored backend Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * JWA: Backend: Add support for Affinity/Tolerations * Extend the configuration yaml with default form values for the affinity/tolerations * Set them accordingly when the user submits a notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* WA: Backend common: update the library Update the common python wheel wrt: * How to distinguish between dev and prod mode * Extra routes for handling Notebooks * Serving the index.html for every non api route (SPA) * Add a STOPPED state to the possible Status values Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * JWA: Add the refactored backend Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * JWA: Backend: Add support for Affinity/Tolerations * Extend the configuration yaml with default form values for the affinity/tolerations * Set them accordingly when the user submits a notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
first step for #5310
Will move the backend under
/components/crud-web-apps/jupyter/backend.All the backend requests will have the following structure:
{ "some-field": "some-value", "status": 200, "success": true, "user": "kimwnasptd", "log": "this field will be present only when the success is false", }Need to append a commit for tolerations and affinity.
We (Arrikto) are deploying this jupyter web app on MiniKF and have extensively tested it. So @elikatsis @yanniszark and @StefanoFioravanzo will most probably not have something big to propose in the review.
cc @thesuperzapper