From 40700cc88202ccd3f9961337c18bae9e5f9d9977 Mon Sep 17 00:00:00 2001 From: Oleksandr Shepotinnik Date: Tue, 8 Nov 2022 20:38:27 +0200 Subject: [PATCH] tensorboard-controller: Fix tensorboard endless restarts --- .../controllers/tensorboard_controller.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/tensorboard-controller/controllers/tensorboard_controller.go b/components/tensorboard-controller/controllers/tensorboard_controller.go index bde099b39d7..315eb002dc5 100644 --- a/components/tensorboard-controller/controllers/tensorboard_controller.go +++ b/components/tensorboard-controller/controllers/tensorboard_controller.go @@ -80,6 +80,14 @@ func (r *TensorboardReconciler) Reconcile(ctx context.Context, req ctrl.Request) return reconcile.Result{}, err } + // tensorboards-web-app deletes objects using foreground deletion policy, Tensorboard CR will stay until all owned objects are deleted + // reconcile loop might keep on trying to recreate the resources that the API server tries to delete. + // so when Tensorboard CR is terminating, reconcile loop should do nothing + + if !instance.DeletionTimestamp.IsZero() { + return ctrl.Result{}, nil + } + // Reconcile k8s deployment. deployment, err := generateDeployment(instance, logger, r) if err != nil {