Sorting support for JWA #6742
Merged
Sorting support for JWA #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenzio9
force-pushed
the
feature-elena-wa-support-sorting
branch
from
06eee57 to
0f49500
Compare
* Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-wa-support-sorting
branch
from
0f49500 to
640dd1d
Compare
This was referenced Nov 15, 2022
|
Built the image and it works as expected. We can go with this approach for now, of doing the sorting in the frontend, but we'll really need to start looking at having some informer/caching mechanism in the backend. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 17, 2022
maroroman
pushed a commit
to maroroman/kubeflow
that referenced
this pull request
Feb 7, 2023
* web-apps(front): Add sorting in common code (kubeflow#6460) * Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Enable sorting in JWA (kubeflow#6460) * Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* web-apps(front): Add sorting in common code (#6460) * Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Enable sorting in JWA (#6460) * Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* web-apps(front): Add sorting in common code (#6460) * Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Enable sorting in JWA (#6460) * Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* web-apps(front): Add sorting in common code (#6460) * Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Enable sorting in JWA (#6460) * Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* web-apps(front): Add sorting in common code (#6460) * Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Enable sorting in JWA (#6460) * Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* web-apps(front): Add sorting in common code (#6460) * Add sorting functionality in the common code. Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Enable sorting in JWA (#6460) * Enable sorting functionality in JWA. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
A screenshot of how it will look like:
The plan is to make VWA and TWA support sorting as well.
Related issue: #6460