Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering support for the web apps #6754

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Filtering support for the web apps #6754

merged 2 commits into from
Nov 23, 2022

Conversation

elenzio9
Copy link
Contributor

This PR adds the filtering functionality in the web apps.

Here some screenshots of how it looks like:
image
image

Related issue: #6462

@elenzio9
web-apps(front): Add filtering functionality in WAs (kubeflow#6462)
cdc7a5e 
* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(front): Differentiate type property (kubeflow#6462)
a06a77d 
* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 force-pushed the feature-elena-wa-support-filtering branch from 2ebd71f to a06a77d Compare November 21, 2022 15:32
@kimwnasptd
Copy link
Member

@elenzio9 I see that the x button is a little bit misaligned. Do you have any insights as to why does this happen?

@elenzio9
Copy link
Contributor Author

elenzio9 commented Nov 23, 2022 •
edited
Loading

@elenzio9 I see that the x button is a little bit misaligned. Do you have any insights as to why does this happen?

Yes indeed. I figured it out and it's related to the @angular/material version. Currently, our apps are using 12.0.x while the styles we need were introduced in 12.2.x. Upgrading the @angular/material version of all apps will fix the misalignment.

@kimwnasptd
Copy link
Member

I see, thanks! Then lets proceed with this and update the @angular/material in all web apps in a follow-up PR

@kimwnasptd
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 23, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 22545c8 into kubeflow:master Nov 23, 2022
@kimwnasptd kimwnasptd deleted the feature-elena-wa-support-filtering branch November 23, 2022 13:47
This was referenced Nov 23, 2022
Merged
Merged
@kimwnasptd kimwnasptd mentioned this pull request Feb 1, 2023
Merged
maroroman pushed a commit to maroroman/kubeflow that referenced this pull request Feb 7, 2023
@elenzio9 @maroroman
Filtering support for the web apps (kubeflow#6754)
bed240e 
* web-apps(front): Add filtering functionality in WAs (kubeflow#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (kubeflow#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd kimwnasptd mentioned this pull request Feb 21, 2023
Closed
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
@elenzio9
Filtering support for the web apps (kubeflow/kubeflow#6754)
a97024e 
* web-apps(front): Add filtering functionality in WAs (#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
@elenzio9 @Adembc
Filtering support for the web apps (kubeflow/kubeflow#6754)
6918d70 
* web-apps(front): Add filtering functionality in WAs (#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
@elenzio9 @Adembc
Filtering support for the web apps (kubeflow/kubeflow#6754)
4761553 
* web-apps(front): Add filtering functionality in WAs (#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
@elenzio9 @Adembc
Filtering support for the web apps (kubeflow/kubeflow#6754)
720c949 
* web-apps(front): Add filtering functionality in WAs (#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
@elenzio9 @Adembc
Filtering support for the web apps (kubeflow/kubeflow#6754)
663c1eb 
* web-apps(front): Add filtering functionality in WAs (#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
@andreyvelich andreyvelich mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanoFioravanzo StefanoFioravanzo Awaiting requested review from StefanoFioravanzo

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees

@kimwnasptd kimwnasptd

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenzio9 @kimwnasptd