web-apps: Add support for all-namespaces in the Volumes and TensorBoards web apps #6778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
StefanoFioravanzo and
thesuperzapper
The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
kimwnasptd
force-pushed
the
feature-kimwnasptd-vtwa-all-namespaces
branch
from
9fc0bf1 to
09b80f1
Compare
|
/assign @tasos-ale |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elikatsis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maroroman
pushed a commit
to maroroman/kubeflow
that referenced
this pull request
Feb 7, 2023
…rds web apps (kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…rds web apps (kubeflow/kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…rds web apps (kubeflow/kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…rds web apps (kubeflow/kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…rds web apps (kubeflow/kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…rds web apps (kubeflow/kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
milinddethe15
pushed a commit
to milinddethe15/dashboard
that referenced
this pull request
Feb 27, 2025
…rds web apps (kubeflow/kubeflow#6778) * vwa(front): Support all-namespaces The VWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * twa(front): Support all-namespaces The TWA will now be able to work with the "All namespaces" option of the CentralDashboard. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * wa(front): Add cypress attributes Add more attributes for elements to be selectable when running e2e tests. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(e2e): Add e2e tests for all-namespaces Add a new e2e test that checks if the Namespaces column is shown when selecting all-namespaces. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * dashboard: Allow all-namespaces for vwa/twa The dashboard will be allowing the VWA and TWA to work with all-namespaces, now that we added this functionality. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last work item for supporting all-namespaces for the web apps https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220621-all-namespaces.md
This PR:
All namespacesoption for the JWA, VWA and TWA