VWA: Create Volume details page #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic in the backend to fetch a single PVC and the pods using it. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Create OVERVIEW tab to show key information about the PVC.
orfeas-k
force-pushed
the
feature-orfeas-vwa-details-page-overview-tab
branch
from
c82cb83 to
4ac91ac
Compare
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 6, 2022
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* vwa(back): Get a single PVC and the pods using it Add logic in the backend to fetch a single PVC and the pods using it. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> * vwa(front): Create Volume details page with OVERVIEW tab Create OVERVIEW tab to show key information about the PVC. * vwa(front): Format files Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* vwa(back): Get a single PVC and the pods using it Add logic in the backend to fetch a single PVC and the pods using it. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> * vwa(front): Create Volume details page with OVERVIEW tab Create OVERVIEW tab to show key information about the PVC. * vwa(front): Format files Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* vwa(back): Get a single PVC and the pods using it Add logic in the backend to fetch a single PVC and the pods using it. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> * vwa(front): Create Volume details page with OVERVIEW tab Create OVERVIEW tab to show key information about the PVC. * vwa(front): Format files Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* vwa(back): Get a single PVC and the pods using it Add logic in the backend to fetch a single PVC and the pods using it. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> * vwa(front): Create Volume details page with OVERVIEW tab Create OVERVIEW tab to show key information about the PVC. * vwa(front): Format files Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* vwa(back): Get a single PVC and the pods using it Add logic in the backend to fetch a single PVC and the pods using it. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> * vwa(front): Create Volume details page with OVERVIEW tab Create OVERVIEW tab to show key information about the PVC. * vwa(front): Format files Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the Details page for each Notebooks/Volumes/TensorBoards effort and we used as a guideline what we 've done for JWA . It creates a new volume details page where a user can navigate and see key information about each volume. More specifically, it includes important information of the PVC focusing on
.specand.statusfields. These can be Access Modes, Size, Storage Class, OwnerReferences, Pods using the PVC.*Regarding Pods using the PVC, these will be grouped into "Pod types". As a first iteration, we will only include the following groups:
NotebookandInferenceServicesince the rest of them require too many requests to deduce about the higher up owning objects. We also want to avoid exposing every pod, since a deployment (like aNotebook) ends up creating aReplicaSetwhich in turn creates another pod and that would result in having duplicate links to the sameNotebookobject.