Skip to content

jwa(front): Rework the create page #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elenzio9
Copy link
Contributor

@elenzio9 elenzio9 commented Dec 8, 2022

This PR reworks JWA's create page by performing the following changes:

  • Remove the namespace input field
  • Have the icon buttons with the logos of the IDEs on top, and hide the image customization into a collapsible section
  • Expanding the Custom Notebook panel allows two different actions:
    • To select among a list of pre-configured images of each type
    • To configure a completely custom image. By checking the Custom Image checkbox, a new Custom Image field appears and the Image field is disabled
  • CPU/RAM
    • Rename Requests CPUs to Minimum CPU, Requested memory in Gi to Minimum Memory Gi, CPU Limit to Maximum CPU, and Memory limit in Gi to Maximum Memory Gi
  • Volumes
    • Limit to just one workspace volume:
      • Hide the add buttons when one workspace volume is present
      • Allow removing the current workspace volume to create a new one and in that case show the two buttons
  • Hide all the sections after the Volumes into an Advanced options expandable section
Click here for some screenshots of how the new page will look like.

image
image
image
image

Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd
Copy link
Member

This is great @elenzio9! The tests pass as well so

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e01deaf into kubeflow:master Dec 15, 2022
@kimwnasptd kimwnasptd deleted the feature-elena-jwa-rework-create-page branch December 15, 2022 09:41
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants