-
Notifications
You must be signed in to change notification settings - Fork 2.5k
jwa(front): Rework the create page #6826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
google-oss-prow
merged 5 commits into
kubeflow:master
from
arrikto:feature-elena-jwa-rework-create-page
Dec 15, 2022
Merged
jwa(front): Rework the create page #6826
google-oss-prow
merged 5 commits into
kubeflow:master
from
arrikto:feature-elena-jwa-rework-create-page
Dec 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
This is great @elenzio9! The tests pass as well so /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* jwa(front): Fix panel.ts file Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Modify form name component Signed-off-by: Elena Zioga <elena@arrikto.com> * web-apps(front): Add a helper tooltip in section component Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Rework the Create page Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Fix linting errors Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* jwa(front): Fix panel.ts file Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Modify form name component Signed-off-by: Elena Zioga <elena@arrikto.com> * web-apps(front): Add a helper tooltip in section component Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Rework the Create page Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Fix linting errors Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* jwa(front): Fix panel.ts file Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Modify form name component Signed-off-by: Elena Zioga <elena@arrikto.com> * web-apps(front): Add a helper tooltip in section component Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Rework the Create page Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Fix linting errors Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* jwa(front): Fix panel.ts file Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Modify form name component Signed-off-by: Elena Zioga <elena@arrikto.com> * web-apps(front): Add a helper tooltip in section component Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Rework the Create page Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Fix linting errors Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* jwa(front): Fix panel.ts file Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Modify form name component Signed-off-by: Elena Zioga <elena@arrikto.com> * web-apps(front): Add a helper tooltip in section component Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Rework the Create page Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(front): Fix linting errors Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks JWA's create page by performing the following changes:
namespace
input fieldCustom Notebook
panel allows two different actions:Custom Image
checkbox, a newCustom Image
field appears and theImage
field is disabledRequests CPUs
toMinimum CPU
,Requested memory in Gi
toMinimum Memory Gi
,CPU Limit
toMaximum CPU
, andMemory limit in Gi
toMaximum Memory Gi
Advanced options
expandable sectionClick here for some screenshots of how the new page will look like.