-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pod Defaults in Tensorboard controller #6874
Conversation
/area jupyter |
components/tensorboard-controller/controllers/tensorboard_controller.go
Outdated
Show resolved
Hide resolved
Looks good, thanks! I'll provide some more context regarding the web app changes as well in the original issue, so that we can push this through #6493 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* support poddefaults in tensorboard controller * initilize empty map
* support poddefaults in tensorboard controller * initilize empty map
* support poddefaults in tensorboard controller * initilize empty map
* support poddefaults in tensorboard controller * initilize empty map
* support poddefaults in tensorboard controller * initilize empty map
This PR adds functionality for adding pod default related labels for tensorboard pods in tensorboard controller. This can be used for various things like configuring cloud storage parameters using environment variables(#6493), service account, tolerations etc.
User experience:
metadata.labels
)Updated the image version because v2.1.0 did not work with IAM roles. Using the latest version would require building and maintaining an image because some functionality is moved out to a different package(tensorflow-io). This package is not installed by default in tensorflow image and I would like to focus on completing the core functionality first.
@kimwnasptd @kandrio @elikatsis
Is there anyone who can help with implementing the webapp frontend related changes or
I would appreciate if anyone can give me a quick intro on the frontend Angular part of the code so I can make the changes myself?