Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pod Defaults in Tensorboard controller #6874

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

surajkota
Copy link
Contributor

@surajkota surajkota commented Jan 4, 2023

This PR adds functionality for adding pod default related labels for tensorboard pods in tensorboard controller. This can be used for various things like configuring cloud storage parameters using environment variables(#6493), service account, tolerations etc.

User experience:

  1. User creates a tensorboard CR with required labels (metadata.labels)
  2. Controller will create the deployment with labels on the pod copied from the tensorboard CR
  3. Admission webhook will take care of injecting necessary configurations according to poddefault

Updated the image version because v2.1.0 did not work with IAM roles. Using the latest version would require building and maintaining an image because some functionality is moved out to a different package(tensorflow-io). This package is not installed by default in tensorflow image and I would like to focus on completing the core functionality first.

@kimwnasptd @kandrio @elikatsis

Is there anyone who can help with implementing the webapp frontend related changes or
I would appreciate if anyone can give me a quick intro on the frontend Angular part of the code so I can make the changes myself?

@jbottum
Copy link
Contributor

jbottum commented Jan 10, 2023

/area jupyter
/kind feature
/priority p2

@kimwnasptd
Copy link
Member

Looks good, thanks! I'll provide some more context regarding the web app changes as well in the original issue, so that we can push this through #6493

@kimwnasptd
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 04b79ef into kubeflow:master Jan 18, 2023
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* support poddefaults in tensorboard controller

* initilize empty map
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* support poddefaults in tensorboard controller

* initilize empty map
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* support poddefaults in tensorboard controller

* initilize empty map
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
* support poddefaults in tensorboard controller

* initilize empty map
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
* support poddefaults in tensorboard controller

* initilize empty map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants