Skip to content

Conversation

@thesuperzapper
Copy link
Member

This PR resolves a lot of outstanding issues with the central dashboard's "manage contributors" page.

The highlights are:

  1. Allow users who are owners of multiple profiles to manage contributors of each:
  2. Display all profiles that users are a member of, split up by role:
    • Owner
    • Contributor
    • Viewer
  3. Significant style improvements (see image below)

Screenshots

Normal User

This screenshot shows a normal user who is not an owner of any profiles, but is a "Contributor" 1 profile and "Viewer" of another.

Screenshot 2024-05-20 at 20 38 30

Admin User

This screenshot shows a user who is an owner of multiple profiles:

Screenshot 2024-05-20 at 20 38 09

Cluster Admin

This screenshot shows a "cluster-admin" user (who can manage all namespaces):

Screenshot 2024-05-20 at 20 38 52

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 21, 2024

We probably have to harden the viewer cluster role later on to make escalations from viewer to editor at least more difficult, but the user interface is so much better this way.

Merging this soon and later iterative improvements is what i would go for.

/lgtm

@ederign
Copy link
Member

ederign commented May 21, 2024

The UI is much better, thank you so much for this @thesuperzapper

/lgtm

@thesuperzapper
Copy link
Member Author

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants