Skip to content

feat: update notebook server images#7590

Merged
google-oss-prow[bot] merged 5 commits intokubeflow:masterfrom
thesuperzapper:update-notebook-servers
May 27, 2024
Merged

feat: update notebook server images#7590
google-oss-prow[bot] merged 5 commits intokubeflow:masterfrom
thesuperzapper:update-notebook-servers

Conversation

@thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented May 27, 2024

This PR updates all the example-notebook-servers images.

The key thing this does is pin h5py==3.10.0 in the jupyter-tensorflow image, because this was causing builds to fail for ARM64, as h5py has stopped shipping wheels for ARM64 in 3.11.0 (h5py/h5py#2408).

Other significant changes:

  • Updated PyTorch to 2.3.0
  • Updated TensorFlow to 2.15.1
  • Updated code-server to: 4.89.1
  • Updated JupyterLab to: 4.2.1
  • Updated Jupyter to 7.2.0
  • Updated RStudio to 2024.04.1-748
  • Updated kfp SDK to: 2.7.0
  • Moved the s6/cont-init.d/01-copy-tmp-home script to only be on the base image, because it was not necessary to have the same code copied across multiple images.

Finally, I have added docs about building the images locally based on feedback from #7587.

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

thesuperzapper commented May 27, 2024

FIXED by updating TensorFlow, which updated typing_extensions to a version that meets ipython requirements ipython/ipython#14380

I am getting a strange error on the jupyter-tensorflow images, which we will need to figure out before merging.

Its probably something simple like that I increased the h5py version too much, and should pin it to a lower version.

Specifically, I am getting this error (NOT DURING BUILD, in the JupyterLab console when running code):

[I 2024-05-27 04:07:50.672 ServerApp]�(B AsyncIOLoopKernelRestarter: restarting kernel (5/5), new random ports
2024-05-27T04:07:50.860691588Z Traceback (most recent call last):
2024-05-27T04:07:50.860720671Z   File "<frozen runpy>", line 198, in _run_module_as_main
2024-05-27T04:07:50.860722838Z   File "<frozen runpy>", line 88, in _run_code
2024-05-27T04:07:50.860724088Z   File "/opt/conda/lib/python3.11/site-packages/ipykernel_launcher.py", line 16, in <module>
2024-05-27T04:07:50.860725504Z     from ipykernel import kernelapp as app
2024-05-27T04:07:50.860726463Z   File "/opt/conda/lib/python3.11/site-packages/ipykernel/kernelapp.py", line 21, in <module>
2024-05-27T04:07:50.860727463Z     from IPython.core.application import (  # type:ignore[attr-defined]
2024-05-27T04:07:50.860728379Z   File "/opt/conda/lib/python3.11/site-packages/IPython/__init__.py", line 55, in <module>
2024-05-27T04:07:50.860729421Z     from .terminal.embed import embed
2024-05-27T04:07:50.860730296Z   File "/opt/conda/lib/python3.11/site-packages/IPython/terminal/embed.py", line 16, in <module>
2024-05-27T04:07:50.860731296Z     from IPython.terminal.interactiveshell import TerminalInteractiveShell
2024-05-27T04:07:50.860732171Z   File "/opt/conda/lib/python3.11/site-packages/IPython/terminal/interactiveshell.py", line 48, in <module>
2024-05-27T04:07:50.860733171Z     from .debugger import TerminalPdb, Pdb
2024-05-27T04:07:50.860734046Z   File "/opt/conda/lib/python3.11/site-packages/IPython/terminal/debugger.py", line 6, in <module>
2024-05-27T04:07:50.860773671Z     from IPython.core.completer import IPCompleter
2024-05-27T04:07:50.860785171Z   File "/opt/conda/lib/python3.11/site-packages/IPython/core/completer.py", line 219, in <module>
2024-05-27T04:07:50.861306963Z     from IPython.core.guarded_eval import guarded_eval, EvaluationContext
2024-05-27T04:07:50.861315546Z   File "/opt/conda/lib/python3.11/site-packages/IPython/core/guarded_eval.py", line 40, in <module>
2024-05-27T04:07:50.861317421Z     from typing_extensions import TypeAliasType
2024-05-27T04:07:50.861318838Z ImportError: cannot import name 'TypeAliasType' from 'typing_extensions' (/opt/conda/lib/python3.11/site-packages/typing_extensions.py)

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

@kimwnasptd this should be ready to review now, all images work in my testing for ARM/X86.

And the CUDA images work with my GPU tests (NOTE: we only ship CUDA on X86, and ARM does not work for them).

@thesuperzapper thesuperzapper removed the request for review from andreyvelich May 27, 2024 08:47
# kubeflow packages
kfp==2.4.0
kfp-server-api==2.0.3
kfp==2.7.0
Copy link
Member

@andreyvelich andreyvelich May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubeflow/wg-notebooks-leads @kubeflow/wg-training-leads Please can we install kubeflow-training and kubeflow-katib Python SDK as part of Kubeflow Notebooks images ?
Similar to KFP python package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular version of these packages that aligns with the 1.9 release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we include the kubeflow-training==1.8.0rc0 and kubeflow-katib==0.17.0rc0 ?
We haven't released the 1.8 and 0.17 version yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich lets wait until the final versions of those packages are released.

Can you try and cut them soon, so we can include them in the next RC?

Adding packages will require me to run all the tests again for all the images, which I don't have time to do before we cut the first RC for 1.9.0.

@kimwnasptd
Copy link
Member

Agree with @thesuperzapper to proceed with this PR for now to cut our first RC. And then let's include the rest in the following RCs

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3f7ecfc into kubeflow:master May 27, 2024
@thesuperzapper thesuperzapper deleted the update-notebook-servers branch May 27, 2024 21:17
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
andyatmiami pushed a commit to andyatmiami/kubeflow-notebooks that referenced this pull request Aug 13, 2025
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
thesuperzapper added a commit to kubeflow/notebooks that referenced this pull request Aug 18, 2025
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
utruong309 pushed a commit to utruong309/notebooks that referenced this pull request Jan 8, 2026
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
utruong309 pushed a commit to utruong309/notebooks that referenced this pull request Jan 8, 2026
* feat: update example notebook server images

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: move `01-copy-tmp-home` to base image

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix: rstudio HOME_TMP copy permissions

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: update `torch` and `tensorflow`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* feat: manually install `tensorrt`

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants