Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seldon Core conversion #10

Closed
cliveseldon opened this issue Mar 19, 2019 · 5 comments

Comments

@cliveseldon
Copy link
Contributor

commented Mar 19, 2019

We'd like to convert the Seldon KSonnet components. Happy to do a PR for this. Any advice/docs on what you did for the existing components to convert them?

@swiftdiaries

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

I did a ks show <environment name> -c <component name> > component.yaml
And then split out the YAML into individual components.
And then for the directory layout, I think you can look at the existing manifests and model them around that.
We currently bake in most of the ksonnet parameters so that the resulting manifest is more or less ready to use off the shelf

@swiftdiaries

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

But I think long term, we need to think about providing a converter so that we can ease migration for end-users like David mentioned at the community meeting.

@jlewi jlewi added the priority/p1 label Jun 26, 2019

@jlewi jlewi added this to New in 0.6.0 via automation Jun 26, 2019

@jlewi jlewi added this to To do in ksonnet-turndown via automation Jun 26, 2019

@jlewi

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

@cliveseldon any chance you could pick this up in the next day or two? Hopefully it should be pretty straightforward.

@cliveseldon

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

There is a PR #36 to add Seldon Kustomize waiting for approval - plus one in kubelow kubeflow/kubeflow#3527

I was following the notes provided kindly by @kkasravi

@jlewi

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

#36 was merged so I'm closing this out.

@jlewi jlewi closed this Aug 4, 2019

ksonnet-turndown automation moved this from To do to Done Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.