Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e workflows against AWS CI #296

Closed
Jeffwan opened this issue Oct 22, 2020 · 5 comments
Closed

Add e2e workflows against AWS CI #296

Jeffwan opened this issue Oct 22, 2020 · 5 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Oct 22, 2020

Community is asking different WG to own their infra and community won't provide a common shared testing infra anymore. Sees kubeflow/testing#752 for more details.

Pytorch migration works well and here's the PR to update test case to work on AWS Prow+ Argo cluster.
kubeflow/pytorch-operator#305

Seems mpi-operator has empty workflow defined https://github.com/kubeflow/mpi-operator/blob/master/prow_config.yaml
Whenever it plans to add real e2e tests, it can follow what pytorch operator did and test each PR before the merge.

@terrytangyuan
Copy link
Member

cc @kubeflow/wg-training-leads

@alculquicondor
Copy link
Collaborator

@Jeffwan, I would like to add E2E tests.

Community is asking different WG to own their infra and community won't provide a common shared testing infra anymore.

Does this mean that the mpi-operator project has to find where to run their tests? Or is there any common infra already in place for the training WG? If so, Is there any guidebook to start adding the workflows and tests?

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 16, 2021

@Jeffwan, I would like to add E2E tests.

Community is asking different WG to own their infra and community won't provide a common shared testing infra anymore.

Does this mean that the mpi-operator project has to find where to run their tests? Or is there any common infra already in place for the training WG? If so, Is there any guidebook to start adding the workflows and tests?

https://github.com/kubeflow/testing/tree/master/aws We use this infra for e2e testing. It can provision the cluster and you can run test against it.

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 16, 2021

/cc @alculquicondor

@alculquicondor
Copy link
Collaborator

We added local tests using kind. This should be enough for now. But thanks for the pointer, maybe it will be useful in the future for more complex workloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants