Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade v2 API to v2beta1 #378

Merged
merged 1 commit into from Jul 16, 2021
Merged

Conversation

alculquicondor
Copy link
Collaborator

Separate from the maturity of the controller, we should consider the maturity of the API.

I believe our current API has room for improvement. So I'd like to state this in the version name. This should be fine as the new API hasn't been announced as released and I would assume no one has been using it in production yet.

@alculquicondor
Copy link
Collaborator Author

/assign @terrytangyuan

To leave the path open for improving the API without having to release a v3.
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Collaborator Author

I forgot to change one import alias

@terrytangyuan
Copy link
Member

/lgtm

@alculquicondor
Copy link
Collaborator Author

not sure why coverage decreased with this. Can this be bypassed?

@terrytangyuan terrytangyuan merged commit 70a866e into kubeflow:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants