Downgrade v2 API to v2beta1#378
Merged
terrytangyuan merged 1 commit intokubeflow:masterfrom Jul 16, 2021
Merged
Conversation
Contributor
Author
|
/assign @terrytangyuan |
To leave the path open for improving the API without having to release a v3.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
I forgot to change one import alias |
Member
|
/lgtm |
Contributor
Author
|
not sure why coverage decreased with this. Can this be bypassed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate from the maturity of the controller, we should consider the maturity of the API.
I believe our current API has room for improvement. So I'd like to state this in the version name. This should be fine as the new API hasn't been announced as released and I would assume no one has been using it in production yet.