Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

fix successPolicy logic #85

Merged
merged 3 commits into from Jul 31, 2020
Merged

Conversation

jasonliu747
Copy link
Member

Occasionally, scheduler would terminate before all workers have finished. This could fix it.

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit test for it? Thanks

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

/lgtm

@jasonliu747
Copy link
Member Author

/assign terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7d243e1 into kubeflow:master Jul 31, 2020
3 of 4 checks passed
@jasonliu747 jasonliu747 deleted the fix-successPolicy branch July 31, 2020 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants