feat(ws): implement delete workspace action with a confirmation popup #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YosiElias
force-pushed
the
deleteWorkspaces
branch
from
ba24d12 to
8cf6058
Compare
paulovmr
suggested changes
Jan 22, 2025
paulovmr
left a comment
paulovmr
left a comment
There was a problem hiding this comment.
Thanks for the PR, @YosiElias ! I've left just one comment, after that it LGTM!
Signed-off-by: yelias <yossi.elias@nokia.com>
YosiElias
force-pushed
the
deleteWorkspaces
branch
from
8cf6058 to
5ef3362
Compare
Signed-off-by: yelias <yossi.elias@nokia.com>
YosiElias
force-pushed
the
deleteWorkspaces
branch
from
5ef3362 to
cab8240
Compare
paulovmr
approved these changes
Jan 23, 2025
ederign
approved these changes
Jan 23, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Closed
Mohamed-ben-khemis
pushed a commit
to Mohamed-ben-khemis/notebooks
that referenced
this pull request
Mar 13, 2025
…kubeflow#178) * feat(ws): Notebooks 2.0 // Frontend // Delete workspace Signed-off-by: yelias <yossi.elias@nokia.com> * Rename deleteModal.tsx Signed-off-by: yelias <yossi.elias@nokia.com> --------- Signed-off-by: yelias <yossi.elias@nokia.com> Co-authored-by: yelias <yossi.elias@nokia.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
…kubeflow#178) * feat(ws): Notebooks 2.0 // Frontend // Delete workspace Signed-off-by: yelias <yossi.elias@nokia.com> * Rename deleteModal.tsx Signed-off-by: yelias <yossi.elias@nokia.com> --------- Signed-off-by: yelias <yossi.elias@nokia.com> Co-authored-by: yelias <yossi.elias@nokia.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
…kubeflow#178) * feat(ws): Notebooks 2.0 // Frontend // Delete workspace Signed-off-by: yelias <yossi.elias@nokia.com> * Rename deleteModal.tsx Signed-off-by: yelias <yossi.elias@nokia.com> --------- Signed-off-by: yelias <yossi.elias@nokia.com> Co-authored-by: yelias <yossi.elias@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #144
Before typing:
Wrong name:
Right name:
