feat(ws): Notebooks 2.0 // Frontend // Workspace details // Applies MUI Theming #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
commented
Jan 23, 2025
Member
Author
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Converting to draft while design details are still being discussed and confirmed.
jenny-s51
force-pushed
the
RHOAI-17689
branch
from
7ec389a to
6583086
Compare
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tab content padding apply horizontal variant to description list, add dividers to match KF central UI update spacer size Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> update font size for description list term
jenny-s51
force-pushed
the
RHOAI-17689
branch
from
6ccef2b to
b19c4cf
Compare
paulovmr
approved these changes
Jan 24, 2025
ederign
approved these changes
Jan 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This was referenced Feb 14, 2025
Mohamed-ben-khemis
pushed a commit
to Mohamed-ben-khemis/notebooks
that referenced
this pull request
Mar 13, 2025
…UI Theming (kubeflow#185) Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tab content padding apply horizontal variant to description list, add dividers to match KF central UI update spacer size Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> update font size for description list term
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
…UI Theming (kubeflow#185) Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tab content padding apply horizontal variant to description list, add dividers to match KF central UI update spacer size Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> update font size for description list term Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
…UI Theming (kubeflow#185) Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tab content padding apply horizontal variant to description list, add dividers to match KF central UI update spacer size Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> update font size for description list term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MUI support to Notebooks 2.0 UI. Applies theming to Workspace details drawer to align with MUI theming and KF Central UI.
Before:
After:
MUI Responsive Drawer:
KF Central UI (Aligns with list styling in "Overview" tab):
