fix(ws): Fix UI bugs in PF Theme #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
changed the title
jenny-s51
force-pushed
the
fix-PF-bugs
branch
2 times, most recently
from
1e260bd to
d0eed20
Compare
|
/ok-to-test |
paulovmr
suggested changes
May 5, 2025
paulovmr
left a comment
paulovmr
left a comment
There was a problem hiding this comment.
Hi @jenny-s51 , the theme looks good to me, I would just say we need to keep MUI as the default style here. Thanks!
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> remove diff file Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix toolbar filter component structure format document Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix formatting Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> Revert default theme to MUI
ederign
approved these changes
May 6, 2025
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> remove diff file Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix toolbar filter component structure format document Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix formatting Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> Revert default theme to MUI Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> remove diff file Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix toolbar filter component structure format document Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix formatting Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> Revert default theme to MUI Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 11, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> remove diff file Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix toolbar filter component structure format document Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix formatting Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> Revert default theme to MUI Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 11, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> remove diff file Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix toolbar filter component structure format document Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix formatting Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> Revert default theme to MUI Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> remove diff file Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix toolbar filter component structure format document Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix formatting Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> Revert default theme to MUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #304
Before:
After:
To test, in const.ts change line 10 to: