From c56dadb31574b7783c26969f0a00e216714e49a2 Mon Sep 17 00:00:00 2001 From: Andy Stoneberg Date: Thu, 9 Oct 2025 08:41:31 -0400 Subject: [PATCH] fix: controller make deploy set image related: #596 When refactoring the controller manifests - a change was missed to ensure the `make deploy` command - which calls `kustomize edit set image ...` properly replaces the `controller` `image` reference. In line with `backend` and `frontend` - the manifest should initially just specify `workspaces-controller` as the image name - and that _exact value_ should then be used in `kustomize edit set image`. This commit brings that alignment into place. Signed-off-by: Andy Stoneberg --- workspaces/controller/Makefile | 2 +- workspaces/controller/config/manager/manager.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/workspaces/controller/Makefile b/workspaces/controller/Makefile index 47985aed..323e14b0 100644 --- a/workspaces/controller/Makefile +++ b/workspaces/controller/Makefile @@ -138,7 +138,7 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified .PHONY: deploy deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config. - cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG} + cd config/manager && $(KUSTOMIZE) edit set image workspaces-controller=${IMG} $(KUSTOMIZE) build config/default | $(KUBECTL) apply -f - .PHONY: undeploy diff --git a/workspaces/controller/config/manager/manager.yaml b/workspaces/controller/config/manager/manager.yaml index 1595fea2..0452b613 100644 --- a/workspaces/controller/config/manager/manager.yaml +++ b/workspaces/controller/config/manager/manager.yaml @@ -53,7 +53,7 @@ spec: - --leader-elect - --health-probe-bind-address=:8081 - --metrics-bind-address=0 - image: workspaces-controller:latest + image: workspaces-controller imagePullPolicy: IfNotPresent name: manager securityContext: