Skip to content

Conversation

@jenny-s51
Copy link
Member

Towards #553.

Closes #554, #555, #556.

Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

revert port address
@caponetto
Copy link

/lgtm

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot requested a review from ederign October 9, 2025 15:21
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Oct 9, 2025
@google-oss-prow google-oss-prow bot requested a review from paulovmr October 9, 2025 15:21
@google-oss-prow google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 size/M labels Oct 9, 2025
@google-oss-prow google-oss-prow bot added the lgtm label Oct 9, 2025
@jenny-s51 jenny-s51 force-pushed the bump-shared-library branch from aa89d42 to 01a97c5 Compare October 9, 2025 15:24
Copy link
Member Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@paulovmr
Copy link

paulovmr commented Oct 9, 2025

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 076d496 into kubeflow:notebooks-v2 Oct 9, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Oct 9, 2025
Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@ederign
Copy link
Member

ederign commented Oct 10, 2025

I reviewed this together with Paulo and forgot to lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants