SDK - Compiler - Using properly serialized pipeline parameter defaults #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@numerology @Bobgy Can you please take a look. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
FYI, @Ark-kun I'm cherry picking this to release-1.0 branch because it seems to fix a lot of issues |
RedbackThomson
pushed a commit
to RedbackThomson/pipelines
that referenced
this pull request
Jun 17, 2020
kubeflow#3832) * SDK - Compiler - Using properly serialized pipeline parameter defaults Fixes kubeflow#3806 * Sort the keys so that the serialized defaults are stable in python 3.5
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
kubeflow#3832) * SDK - Compiler - Using properly serialized pipeline parameter defaults Fixes kubeflow#3806 * Sort the keys so that the serialized defaults are stable in python 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2825
Fixes #2840
Fixes #3806
Not Fixes #2534