Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Python - Switched the default base image to python 3.7 #4054

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 23, 2020

Previously the default image was set to an old version of tensorflow image. That image is now outdated. It's also framework-specific and pretty big.
We're switching to the official python image which is small, official and framework-agnostic.
The users can easily switch to the old behavior by just specifying base_image='tensorflow/tensorflow:1.13.2-py3' during the component creation.

This also allows us to use the image corresponding to the current python environment. This makes code pickling significantly safer.

Fixes #4041
Closes: #4062

… 3.7

Previously the default image was set to an old version of tensorflow image. That image is now outdated. It's also framework-specific and pretty big.
We're switching to the official python image which is small, official and framework-agnostic.
The users can easily switch to the old behavior by just specifying `base_image='tensorflow/tensorflow:1.13.2-py3'` during the component creation.
@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Jun 23, 2020

/lgtm
Thanks @Ark-kun!

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 23, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 23, 2020

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 23, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 24, 2020

/retest

3 similar comments
@Bobgy
Copy link
Contributor

Bobgy commented Jun 24, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 24, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 24, 2020

/retest

@Ark-kun Ark-kun added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jun 24, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 24, 2020

/retest

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

4 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 25, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit ceb860c into kubeflow:master Jun 25, 2020
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Jul 2, 2020
@engineeryashsaxena
Copy link

hu @Bobgy do you know how can I use a high memory base image while creating a component from function, I am currently getting OOM issues

@Bobgy
Copy link
Contributor

Bobgy commented Aug 20, 2021

@engineeryashsaxena Image is not related to memory.
See https://github.com/kubeflow/pipelines/blob/master/samples/core/resource_spec/resource_spec.py. Any task can be configured with more memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/sdk/components/python_container_op area/sdk/components area/sdk cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` lgtm size/S
Projects
None yet
7 participants