Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Implement comprehensive unit tests for the KFP SDK Client class #8126

Closed
droctothorpe opened this issue Aug 10, 2022 · 2 comments
Closed
Labels
area/sdk kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@droctothorpe
Copy link
Contributor

droctothorpe commented Aug 10, 2022

Feature Area

/area sdk

What feature would you like to see?

We would like to see comprehensive unit tests for the KFP SDK Client class to improve confidence in code changes.

The existing coverage looks quite sparse.

My team and I would be interested in contributing this to the upstream but want to make sure that we're not stepping on anyone's toes / it makes sense to core maintainers.

What is the use case or pain point?

Reduced confidence in code changes / releases.

Is there a workaround currently?

No.


Love this idea? Give it a 👍.

@droctothorpe droctothorpe changed the title [feature] Unit tests for KFP SDK Client [feature] Implement comprehensive unit tests for the KFP SDK Client class Aug 10, 2022
@chensun
Copy link
Member

chensun commented Aug 11, 2022

Hi @droctothorpe feel free to contribute ? JFYI, here're some example code on how we tested the v2 Vertex client (which was moved out of KFP package in the master branch): https://github.com/kubeflow/pipelines/tree/sdk/release-1.8/sdk/python/kfp/v2/google/client

Copy link

github-actions bot commented Mar 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
Status: Closed
Development

No branches or pull requests

2 participants