-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes_platform): Update kubernetes_platform go package to i… #10442
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @droctothorpe. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @droctothorpe, overall the new definition looks good to me other than a minor format fix. Can you rebase this PR to the master branch and regenerate the go package? Thank you.
126d4f7
to
addf158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @droctothorpe
/lgtm
/assign @connor-mccarthy |
addf158
to
cd994a1
Compare
Rebased and resolved conflicts. |
cd994a1
to
a5d9395
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@droctothorpe can you rebase this PR? I think you need this to merge first because the backend is pulling the package from github upstream instead of local packages. /cc @connor-mccarthy |
I'm going to close this PR in favor of #10471, which is a superset of this one (it includes the driver and SDK changes as well). |
a5d9395
to
fd86e83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Need to rebase again after the last merge to master but won't have a chance to until this evening (when I have access to my personal laptop). Apologies for the delay. |
…nclude tolerations Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
fd86e83
to
4b39e61
Compare
Rebase complete. Thanks for your patience! @Tomcli. |
thanks @droctothorpe, |
/cc @connor-mccarthy |
@droctothorpe: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Woohoo ty friends! |
Do you guys know when you guys are going to release this feature? I see the latest is 2.0.5 from Dec 2023 |
kubeflow#10442) Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
kubeflow#10442) Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
kubeflow#10442) Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
kubeflow#10442) Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
…nclude tolerations
Description of your changes:
This PR adds tolerations to the kubernetes platform proto file. It also regenerates the Golang stub.
It follows the piece-meal approach that @Tomcli led by example with in this PR and clarified in this comment.
We will submit a follow up PR that updates
driver.go
and another PR that updates the SDK.The toleration message mimics the message in the core K8s tolerations proto.
This will let us use V2 with GPUs.
Relevant issues: #9682, #9768, and #10252.
Checklist: