Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating runs without experiments #1175

Merged

PR comments

  • Loading branch information...
rileyjbauer committed Apr 19, 2019
commit 53e4d45cf36241c34e3fe7044e41d89059cbed73
@@ -77,6 +77,8 @@ class AllRunsList extends Page<{}, AllRunsListState> {

private _selectionChanged(selectedIds: string[]): void {
const toolbarActions = [...this.props.toolbarProps.actions];
// TODO: keeping track of indices in the toolbarActions array is not ideal. This should be
// refactored so that individual buttons can be referenced with something other than indices.
// Compare runs button
toolbarActions[2].disabled = selectedIds.length <= 1 || selectedIds.length > 10;
// Clone run button
@@ -250,7 +250,7 @@ describe('deploy helloworld sample run', () => {
}, waitTimeout);
});

it('displays both custom and default experiment experiment list page', () => {
it('displays both custom and default experiment in the list', () => {
$('.tableRow').waitForVisible();
const rows = $$('.tableRow').length;
assert(rows === 2, 'there should now be two experiments in the table, instead there are: ' + rows);

This comment has been minimized.

Copy link
@yebrahim

yebrahim Apr 18, 2019

Contributor

I'm curious, does the default experiment disappear if this experiment-less run goes away? What if it's archived for example?

This comment has been minimized.

Copy link
@rileyjbauer

rileyjbauer Apr 19, 2019

Author Contributor

Nope. Experiments can exist without runs

@@ -74,13 +74,17 @@ POD=`/src/tools/google-cloud-sdk/bin/kubectl get pods -n ${NAMESPACE} -l app=ml-
./node_modules/.bin/wait-port 127.0.0.1:3000 -t 20000

export PIPELINE_OUTPUT=${RESULTS_GCS_DIR}/pipeline_output

JUNIT_TEST_RESULT=junit_FrontendIntegrationTestOutput.xml

# Don't exit early if 'npm test' fails
set +e
npm test
TEST_RESULT=`npm test 2>&1`
TEST_EXIT_CODE=$?
set -e

JUNIT_TEST_RESULT=junit_FrontendIntegrationTestOutput.xml
# Log the test result
printf '%s\n' "$TEST_RESULT"
# Convert test result to junit.xml
printf '%s\n' "$TEST_RESULT" | go-junit-report > ${JUNIT_TEST_RESULT}

echo "Copy test result to GCS ${RESULTS_GCS_DIR}/${JUNIT_TEST_RESULT}"
tools/google-cloud-sdk/bin/gsutil cp ${JUNIT_TEST_RESULT} ${RESULTS_GCS_DIR}/${JUNIT_TEST_RESULT}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.